Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyring migrate command doc #8979

Merged
merged 17 commits into from
Apr 12, 2021
Merged

Keyring migrate command doc #8979

merged 17 commits into from
Apr 12, 2021

Conversation

cyberbono3
Copy link
Contributor

Description

This is draft PR that describes keyring migrate command.

closes: #8769

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

amaury1093
amaury1093 reviewed Mar 24, 2021
View reviewed changes
docs/migrations/keyring.md Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
amaury1093
amaury1093 reviewed Mar 29, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @cyberbono3, thanks! is this r4r?

docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
@amaury1093 amaury1093 added backport/0.42.x (Stargate) T:Docs Changes and features related to documentation. labels Mar 29, 2021
@cyberbono3 cyberbono3 force-pushed the cyberbono3/8769-add-migration-keyring-doc branch 3 times, most recently from e691eea to 61ea86f Compare March 29, 2021 21:24
@cyberbono3 cyberbono3 force-pushed the cyberbono3/8769-add-migration-keyring-doc branch from 61ea86f to 56052b7 Compare March 29, 2021 21:29
@cyberbono3
Copy link
Contributor Author

@AmauryM Can you review it, please?

@amaury1093
Copy link
Contributor

@cyberbono3 In the SDK, we generally don't put the ready-for-review label, but just put the PR as "open", which means that other people are invited to review it.

@amaury1093 amaury1093 marked this pull request as ready for review March 30, 2021 09:28
@cyberbono3
Copy link
Contributor Author

@cyberbono3 In the SDK, we generally don't put the ready-for-review label, but just put the PR as "open", which means that other people are invited to review it.

OK. Thanks for your clarification.

@cyberbono3
Copy link
Contributor Author

@AmauryM Do you know how to fix rosetta?

@amaury1093
Copy link
Contributor

@AmauryM Do you know how to fix rosetta?

Not really... #8772

barriebyron
barriebyron reviewed Mar 31, 2021
View reviewed changes
Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should write a numbered list of how to migrate keypairs from Launchpad to Stargate?

  1. simd keys migrate <old_home_dir> --dry-run true
  2. (how do we test that the keypairs migrated?)
  3. simd keys migrate <old_home_dir> --dry-run false

docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
docs/migrations/keyring.md Outdated Show resolved Hide resolved
sahith-narahari
sahith-narahari suggested changes Apr 6, 2021
View reviewed changes
docs/migrations/keyring.md Outdated Show resolved Hide resolved
cyberbono3 and others added 8 commits April 6, 2021 12:32
@cyberbono3
Update docs/migrations/keyring.md
85297df 
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
@cyberbono3
Update docs/migrations/keyring.md
5c5bb1d 
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
@cyberbono3
Update docs/migrations/keyring.md
6724b1a 
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
@cyberbono3
Update docs/migrations/keyring.md
ae849a0 
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
@cyberbono3
Update docs/migrations/keyring.md
4464c21 
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
@cyberbono3
Update docs/migrations/keyring.md
a77f5e0 
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
@cyberbono3
Update docs/migrations/keyring.md
c354edb 
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Merge branch 'master' into cyberbono3/8769-add-migration-keyring-doc
cd5e118
amaury1093
amaury1093 approved these changes Apr 7, 2021
View reviewed changes
docs/migrations/keyring.md Outdated Show resolved Hide resolved
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 12, 2021
@mergify mergify bot merged commit d5f5fe6 into master Apr 12, 2021
@mergify mergify bot deleted the cyberbono3/8769-add-migration-keyring-doc branch April 12, 2021 10:18
@amaury1093
Copy link
Contributor

@Mergifyio backport release/v0.42.x

mergify bot pushed a commit that referenced this pull request May 3, 2021
@cyberbono3
Keyring migrate command doc (#8979)
7b1a1b5 
* draft

* update

* address comments, ready for review

* delete thr last line

* Update docs/migrations/keyring.md

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

* Update docs/migrations/keyring.md

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

* Update docs/migrations/keyring.md

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

* Update docs/migrations/keyring.md

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

* Update docs/migrations/keyring.md

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

* Update docs/migrations/keyring.md

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

* Update docs/migrations/keyring.md

Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>

* ready for review

* Update docs/migrations/keyring.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
(cherry picked from commit d5f5fe6)
@mergify mergify bot mentioned this pull request May 3, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented May 3, 2021

Command backport release/v0.42.x: success

Backports have been created

alessio pushed a commit that referenced this pull request May 3, 2021
@mergify @sahith-narahari
@amaury1093 @cyberbono3
Keyring migrate command doc (#8979) (#9254)
78e9ce9 
Co-authored-by: SaReN <sahithnarahari@gmail.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
(cherry picked from commit d5f5fe6)
Co-authored-by: Andrei Ivasko <cyberbono3@gmail.com>
This was referenced Feb 7, 2024
Closed
Closed
Closed
@neutron-robot neutron-robot mentioned this pull request Feb 14, 2024
Closed
This was referenced Apr 28, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahith-narahari sahith-narahari sahith-narahari approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jgimeno jgimeno Awaiting requested review from jgimeno

@clevinson clevinson Awaiting requested review from clevinson

@barriebyron barriebyron Awaiting requested review from barriebyron

Assignees

@sahith-narahari sahith-narahari

Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update keyring migrate documentation for v0.42 and version specific migrations
4 participants
@cyberbono3 @amaury1093 @barriebyron @sahith-narahari