-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: grpc-gateway error codes #9015
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9015 +/- ##
==========================================
- Coverage 58.87% 58.87% -0.01%
==========================================
Files 572 573 +1
Lines 32073 32091 +18
==========================================
+ Hits 18884 18893 +9
- Misses 10978 10987 +9
Partials 2211 2211
|
Should we backport this? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, could you add a changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @aleem1314
hmm, it seems like mergify doesn't backport automatically anymore. @Mergifyio backport release/v0.42.x ? |
Command
|
@Mergifyio backport release/v0.42.x |
Command
|
@Mergifyio backport release/v0.42.x |
Command
|
@Mergifyio backport release/v0.42.x |
Command
|
@Mergifyio backport release/v0.42.x |
Command
|
@Mergifyio backport release/v0.42.x |
Command
|
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=f1e194cdbb6b4a158139d5285533172c |
Benchmark finished. See the result: https://github.orijtech.com/benchmark/result?id=1641198dae3248379927641d7c61f1c3 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=636e6598b96c019647e9ef69f69a9f8fee435e79 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=1d341a4a34bea11e55a28eeed6ba4f833bc514ee |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=d3b90bac2b64e5f21cf80004a244c4d0dbbe16c5 |
Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Description
closes: #8902
closes: #8652
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes