-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor auth cli tests #9018
Refactor auth cli tests #9018
Conversation
@robert-zaremba is there anything else you feel I should look at in this file, other than the repetitions addressed here |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=a87bf88221e77f8534bc0610168b6646b88bc9de |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=f1797ad0c79a0821cd2cda8b1b73709261ac0fb4 |
Benchmark beginning. Status page: https://github.orijtech.com/benchmark/status?commit=1e9ce95c98fdc94a5617328c158c7bdf6a52fe49 |
i remember there was a related issue, right? Could you link it in the OP @sahith-narahari ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #9018 +/- ##
==========================================
+ Coverage 58.95% 58.99% +0.03%
==========================================
Files 574 575 +1
Lines 32213 32198 -15
==========================================
+ Hits 18992 18996 +4
+ Misses 11002 10985 -17
+ Partials 2219 2217 -2
|
Description
ref: #8711
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes