Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor auth cli tests #9018

Merged
merged 13 commits into from
Apr 7, 2021
Merged

Refactor auth cli tests #9018

merged 13 commits into from
Apr 7, 2021

Conversation

sahith-narahari
Copy link
Contributor

@sahith-narahari sahith-narahari commented Mar 29, 2021

Description

ref: #8711


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@sahith-narahari
Copy link
Contributor Author

@robert-zaremba is there anything else you feel I should look at in this file, other than the repetitions addressed here

@orijbot
Copy link

orijbot commented Mar 29, 2021

@orijbot
Copy link

orijbot commented Mar 29, 2021

@orijbot
Copy link

orijbot commented Mar 29, 2021

@sahith-narahari sahith-narahari marked this pull request as ready for review April 5, 2021 18:50
@sahith-narahari sahith-narahari added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Apr 6, 2021
@amaury1093
Copy link
Contributor

i remember there was a related issue, right? Could you link it in the OP @sahith-narahari ?

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sahith-narahari sahith-narahari added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #9018 (542119a) into master (29ff333) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 542119a differs from pull request most recent head 581e50e. Consider uploading reports for the commit 581e50e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9018      +/-   ##
==========================================
+ Coverage   58.95%   58.99%   +0.03%     
==========================================
  Files         574      575       +1     
  Lines       32213    32198      -15     
==========================================
+ Hits        18992    18996       +4     
+ Misses      11002    10985      -17     
+ Partials     2219     2217       -2     
Impacted Files Coverage Δ
server/grpc/server.go 62.50% <0.00%> (-2.72%) ⬇️
x/bank/keeper/querier.go 74.13% <0.00%> (-1.73%) ⬇️
x/staking/simulation/operations.go 73.16% <0.00%> (-0.30%) ⬇️
types/address.go 64.75% <0.00%> (ø)
baseapp/grpcrouter.go 80.00% <0.00%> (ø)
types/query/pagination.go 80.00% <0.00%> (ø)
x/auth/legacy/legacytx/stdsign.go 82.81% <0.00%> (ø)
client/grpc/reflection/reflection.go 55.55% <0.00%> (ø)
x/staking/types/msg.go 55.55% <0.00%> (+0.62%) ⬆️
x/bank/client/cli/query.go 68.90% <0.00%> (+0.87%) ⬆️
... and 4 more

@mergify mergify bot merged commit a3b3a67 into master Apr 7, 2021
@mergify mergify bot deleted the sahith/refactor-auth-tests branch April 7, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Tests Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants