Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddAmount/SubAmount methods to sdk.Coin #9091

Merged
merged 6 commits into from
Apr 13, 2021
Merged

Add AddAmount/SubAmount methods to sdk.Coin #9091

merged 6 commits into from
Apr 13, 2021

Conversation

hallazzang
Copy link
Contributor

Description

closes: #9079


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hallazzang
Copy link
Contributor Author

Need to decide whether to add AddAmountInt64/SubAmountInt64 methods to follow NewInt64Coin convention.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #9091 (8eb9758) into master (a4c7fd7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9091   +/-   ##
=======================================
  Coverage   58.82%   58.83%           
=======================================
  Files         580      580           
  Lines       32643    32648    +5     
=======================================
+ Hits        19203    19208    +5     
  Misses      11174    11174           
  Partials     2266     2266           
Impacted Files Coverage Δ
types/coin.go 93.27% <100.00%> (+0.15%) ⬆️

@hallazzang hallazzang marked this pull request as ready for review April 10, 2021 16:10
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 12, 2021
@mergify mergify bot merged commit cf7b03e into cosmos:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AddAmount/SubAmount method to sdk.Coin
4 participants