Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/authz & x/feegrant: documentation for gas consumption #9118

Merged
merged 3 commits into from
Apr 15, 2021
Merged

x/authz & x/feegrant: documentation for gas consumption #9118

merged 3 commits into from
Apr 15, 2021

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Apr 15, 2021 •
edited
Loading

Description

This PR adds a section about gas consumption for x/authz & x/feegrant spec documentation.

Related PRs: #8995 & #8604

closes: #9068

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

tac0turtle
tac0turtle approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the additions. Do we need to say how much the gas is and how to change this, if possible?

atheeshp
atheeshp approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@amaury1093 amaury1093 added A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation. labels Apr 15, 2021
@mergify mergify bot merged commit bc4c3be into master Apr 15, 2021
@mergify mergify bot deleted the ty-9068-gas branch April 15, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheeshp atheeshp atheeshp approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alessio alessio Awaiting requested review from alessio

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@amaury1093 amaury1093 Awaiting requested review from amaury1093

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade x/authz & x/fee_grant documentation with gas costs
4 participants
@technicallyty @tac0turtle @atheeshp @amaury1093