Rename memo to note inside CLI

[anilcse]

Description

ref: #9122

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer
• Review Codecov Report in the comment section below once CI passes

[codecov]

Codecov Report

Merging #9134 (f82780c) into master (3e6c4a6) will decrease coverage by 0.07%.
The diff coverage is 33.33%.

❗ Current head f82780c differs from pull request most recent head e5a4ef5. Consider uploading reports for the commit e5a4ef5 to get more accurate results

@@            Coverage Diff             @@
##           master    #9134      +/-   ##
==========================================
- Coverage   60.13%   60.06%   -0.08%     
==========================================
  Files         595      595              
  Lines       37192    37355     +163     
==========================================
+ Hits        22367    22437      +70     
- Misses      12846    12929      +83     
- Partials     1979     1989      +10     

Impacted Files	Coverage Δ
client/flags/flags.go	22.22% <0.00%> (ø)
client/tx/factory.go	28.20% <0.00%> (ø)
x/auth/client/testutil/suite.go	95.41% <100.00%> (+0.09%)	⬆️
x/bank/client/testutil/cli_helpers.go	8.10% <0.00%> (-41.90%)	⬇️
types/codec.go	50.00% <0.00%> (-16.67%)	⬇️
store/internal/proofs/create.go	67.56% <0.00%> (-13.83%)	⬇️
x/gov/client/utils/query.go	25.72% <0.00%> (-2.44%)	⬇️
x/auth/legacy/legacytx/stdtx_builder.go	56.00% <0.00%> (-1.58%)	⬇️
server/rosetta/converter.go	54.44% <0.00%> (-1.52%)	⬇️
x/staking/client/rest/query.go	40.66% <0.00%> (-1.21%)	⬇️
... and 33 more

[tac0turtle]

@anilcse what is the status with this pr?

[amaury1093]

lgtm

[tac0turtle]

is this only a cli issue or also a rest issue?

should it be modified for baseReq?

cosmos-sdk/types/rest/rest.go

Line 66 in 7f59723

Memo string `json:"memo"`

EDIT: should be fine. REST will be protected via client apps

[fedekunze]

is this the only reference we have/need to change? I found many other references for Memo on the code other than the flag

[fedekunze]

if not it's ok but I'm just confused by the title of the PR

[blushi]

see #9122 (comment)

[alexanderbez]

I can't believe we need this PR... 🤦 Why anyone would put their mnemonic in the memo field is beyond me and clearly demonstrates they should not be using CLI tools targeted for power users.

[amaury1093]

@atheeshp Could you fix the conflicts, and we merge this!