Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/feegrant simulation audit changes #9145

Merged
merged 15 commits into from
Apr 27, 2021
Merged

x/feegrant simulation audit changes #9145

merged 15 commits into from
Apr 27, 2021

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Apr 20, 2021

Description

#9029 (comment)

ref: #9115


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #9145 (e9eda4e) into master (fdbc32e) will increase coverage by 0.01%.
The diff coverage is 67.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9145      +/-   ##
==========================================
+ Coverage   59.71%   59.72%   +0.01%     
==========================================
  Files         595      595              
  Lines       37318    37346      +28     
==========================================
+ Hits        22284    22306      +22     
- Misses      13056    13059       +3     
- Partials     1978     1981       +3     
Impacted Files Coverage Δ
x/feegrant/simulation/operations.go 76.99% <0.00%> (ø)
x/feegrant/types/msgs.go 0.00% <ø> (ø)
x/feegrant/simulation/genesis.go 79.48% <81.81%> (-2.34%) ⬇️

@atheeshp atheeshp marked this pull request as ready for review April 23, 2021 07:43
@blushi blushi mentioned this pull request Apr 23, 2021
7 tasks
x/feegrant/simulation/genesis.go Outdated Show resolved Hide resolved
Co-authored-by: Marie Gauthier <marie.gauthier63@gmail.com>
@blushi blushi added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 27, 2021
@mergify mergify bot merged commit fc256a3 into master Apr 27, 2021
@mergify mergify bot deleted the atheesh/simulation-audit branch April 27, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/feegrant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants