Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fuzz: add crypto/types.BitArray CompactUnmarshal fuzzer #9166

Merged
merged 1 commit into from
Apr 22, 2021
Merged

fuzz: add crypto/types.BitArray CompactUnmarshal fuzzer #9166

merged 1 commit into from
Apr 22, 2021

Conversation

odeke-em
Copy link
Collaborator

Updates #9165

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

/cc @cuonglm

alessio
alessio previously requested changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd appreciate if you could move al this (useful) fuzzy infrastructure under the contrib directory.

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2021

This pull request introduces 1 alert when merging 20cc8c1a57b35b39938090c0f6d4b6f807598426 into 36312cd - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@odeke-em
Copy link
Collaborator Author

I'd appreciate if you could move al this (useful) fuzzy infrastructure under the contrib directory.

@alessio we currently fuzzing everything directly under fuzz/ and not yet adding our work to master, otherwise it would bloat up the repos and we have to submit it to oss-fuzz which runs continuously. When we are merging to master eventually, for sure we'll move it to contrib :-) Thank you for the suggestion! Thank you for the review @cuonglm, I've made the update!

@odeke-em odeke-em dismissed alessio’s stale review April 22, 2021 09:45

Not applicable for this branch, but thank you for the suggestion and review!

@odeke-em odeke-em merged commit 1651a63 into cosmos:fuzz-packages Apr 22, 2021
@odeke-em odeke-em deleted the fuzz-crypto.BitArray.CompactUnmarshal branch April 22, 2021 09:46
@odeke-em
Copy link
Collaborator Author

@cuonglm I've merged the PR, and also previously updated fuzz-packages. Please help me with the other updates to ensure oss-fuzz picks this one up. Thank you again!

odeke-em added a commit that referenced this pull request Apr 24, 2021
@odeke-em
fuzz: add crypto/types.BitArray CompactUnmarshal fuzzer (#9166)
df264f2 
Updates #7921.
odeke-em added a commit that referenced this pull request Apr 24, 2021
@odeke-em
fuzz: add tendermint/go-amino.DecodeTime (#9195)
d9677d9 
go-amino is a heavily used dependency and given that
Tendermrint isn't yet setup for oss-fuzz, this change
is a start for it.

While here, add the oss-fuzz entry for crypto/types.BitArray
CompactUnmarshal fuzzer for PR #9166.

Updates #7921
odeke-em added a commit that referenced this pull request Jul 22, 2021
@odeke-em
fuzz: add crypto/types.BitArray CompactUnmarshal fuzzer (#9166)
16fde04 
Updates #7921.
odeke-em added a commit that referenced this pull request Jul 22, 2021
@odeke-em
fuzz: add tendermint/go-amino.DecodeTime (#9195)
e12c4d5 
go-amino is a heavily used dependency and given that
Tendermrint isn't yet setup for oss-fuzz, this change
is a start for it.

While here, add the oss-fuzz entry for crypto/types.BitArray
CompactUnmarshal fuzzer for PR #9166.

Updates #7921
odeke-em added a commit that referenced this pull request Jul 28, 2021
@odeke-em
fuzz: add crypto/types.BitArray CompactUnmarshal fuzzer (#9166)
b65597a 
Updates #7921.
odeke-em added a commit that referenced this pull request Jul 28, 2021
@odeke-em
fuzz: add tendermint/go-amino.DecodeTime (#9195)
3cccf9e 
go-amino is a heavily used dependency and given that
Tendermrint isn't yet setup for oss-fuzz, this change
is a start for it.

While here, add the oss-fuzz entry for crypto/types.BitArray
CompactUnmarshal fuzzer for PR #9166.

Updates #7921
odeke-em added a commit that referenced this pull request Mar 30, 2022
@odeke-em
fuzz: add crypto/types.BitArray CompactUnmarshal fuzzer (#9166)
f8cd984 
Updates #7921.
odeke-em added a commit that referenced this pull request Mar 30, 2022
@odeke-em
fuzz: add tendermint/go-amino.DecodeTime (#9195)
a463cba 
go-amino is a heavily used dependency and given that
Tendermrint isn't yet setup for oss-fuzz, this change
is a start for it.

While here, add the oss-fuzz entry for crypto/types.BitArray
CompactUnmarshal fuzzer for PR #9166.

Updates #7921
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request Apr 11, 2022
@odeke-em @elias-orijtech
fuzz: add crypto/types.BitArray CompactUnmarshal fuzzer (cosmos#9166)
7d5058b 
Updates cosmos#7921.
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request Apr 11, 2022
@odeke-em @elias-orijtech
fuzz: add tendermint/go-amino.DecodeTime (cosmos#9195)
4c426df 
go-amino is a heavily used dependency and given that
Tendermrint isn't yet setup for oss-fuzz, this change
is a start for it.

While here, add the oss-fuzz entry for crypto/types.BitArray
CompactUnmarshal fuzzer for PR cosmos#9166.

Updates cosmos#7921
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request May 6, 2022
@odeke-em @elias-orijtech
fuzz: add crypto/types.BitArray CompactUnmarshal fuzzer (cosmos#9166)
be1c07e 
Updates cosmos#7921.
elias-orijtech pushed a commit to elias-orijtech/cosmos-sdk that referenced this pull request May 6, 2022
@odeke-em @elias-orijtech
fuzz: add tendermint/go-amino.DecodeTime (cosmos#9195)
0e5b2f9 
go-amino is a heavily used dependency and given that
Tendermrint isn't yet setup for oss-fuzz, this change
is a start for it.

While here, add the oss-fuzz entry for crypto/types.BitArray
CompactUnmarshal fuzzer for PR cosmos#9166.

Updates cosmos#7921
odeke-em added a commit that referenced this pull request Jun 4, 2022
@odeke-em
fuzz: add crypto/types.BitArray CompactUnmarshal fuzzer (#9166)
d0df73a 
Updates #7921.
odeke-em added a commit that referenced this pull request Jun 4, 2022
@odeke-em
fuzz: add tendermint/go-amino.DecodeTime (#9195)
1f66054 
go-amino is a heavily used dependency and given that
Tendermrint isn't yet setup for oss-fuzz, this change
is a start for it.

While here, add the oss-fuzz entry for crypto/types.BitArray
CompactUnmarshal fuzzer for PR #9166.

Updates #7921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuonglm cuonglm cuonglm requested changes

@alessio alessio alessio left review comments

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odeke-em @alessio @cuonglm