crypto/types: fix negative index accesses in CompactUnmarshal,GetIndex,SetIndex #9196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuonglm
approved these changes
Apr 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #9196 +/- ##
=======================================
Coverage 59.70% 59.71%
=======================================
Files 595 595
Lines 37315 37317 +2
=======================================
+ Hits 22279 22283 +4
+ Misses 13057 13056 -1
+ Partials 1979 1978 -1
|
9 tasks
tac0turtle
approved these changes
Apr 26, 2021
amaury1093
approved these changes
Apr 26, 2021
tac0turtle
added
the
A:automerge
|
@odeke-em can you enable maintainers to modify the PR. This will allow the mergify bot to handle merging this PR |
alessio
approved these changes
Apr 26, 2021
|
Thanks for the reviews and approvals @alessio @cuonglm @AmauryM @marbar3778! @marbar3778 am not sure how to enable that but the branch got out of date from changes on the master branch, and auto merge has been applied before in other PRs of mine. |
odeke-em
deleted the
crypto-types-CompactBitArray-fix-negative-index-access
branch
odeke-em
pushed a commit
that referenced
this pull request
Apr 26, 2021
odeke-em
pushed a commit
that referenced
this pull request
Jul 22, 2021
odeke-em
pushed a commit
that referenced
this pull request
Jul 28, 2021
odeke-em
pushed a commit
that referenced
this pull request
Mar 30, 2022
elias-orijtech
pushed a commit
to elias-orijtech/cosmos-sdk
that referenced
this pull request
Apr 11, 2022
elias-orijtech
pushed a commit
to elias-orijtech/cosmos-sdk
that referenced
this pull request
May 6, 2022
odeke-em
pushed a commit
that referenced
this pull request
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unchecked negative index access that'd cause panics, in CompactBitArray's:
Fixes #9164
Fixes #9165
/cc @cuonglm, we'll need to write fuzz passes to ensure that these code paths don't regress.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes