fix zero coins #9229
Merged
fix zero coins #9229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested commit |
atheeshp
requested review from
aleem1314,
anilcse,
blushi,
clevinson,
colin-axner and
cyberbono3
Codecov Report
@@ Coverage Diff @@
## master #9229 +/- ##
==========================================
+ Coverage 60.06% 60.12% +0.06%
==========================================
Files 595 595
Lines 37355 37190 -165
==========================================
- Hits 22437 22361 -76
+ Misses 12929 12848 -81
+ Partials 1989 1981 -8
|
fedekunze
reviewed
Apr 29, 2021
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
amaury1093
reviewed
Apr 30, 2021
… into atheesh/fix-zero-coins
fedekunze
approved these changes
Apr 30, 2021
alexanderbez
approved these changes
Apr 30, 2021
robert-zaremba
approved these changes
Apr 30, 2021
x/bank/keeper/keeper_test.go
Outdated
|
|
||
| // add module accounts to supply keeper | ||
| maccPerms := getModuleAccPerms() | ||
| authKeeper := authkeeper.NewAccountKeeper( |
There was a problem hiding this comment.
I think you can add authKeepr and bank keeper constructor to the same function - it's always used and repeated next to the maccPerms.
amaury1093
added
the
A:automerge
mergify bot
pushed a commit
that referenced
this pull request
Apr 30, 2021
* fix zero coins issue * fix tests * udpate tests * Review change Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * add change log * review changes * review changes Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit f04b5dc) # Conflicts: # CHANGELOG.md # x/bank/keeper/genesis_test.go # x/bank/keeper/keeper.go # x/bank/keeper/keeper_test.go # x/bank/keeper/send.go
|
@AmauryM did we do a migration for this? i.e. are we deleting zero balances for chains upgrading to 0.43? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #9159
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes