Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/gov v0.43 Audit updates #9258

Merged
merged 10 commits into from
May 7, 2021
Merged

x/gov v0.43 Audit updates #9258

merged 10 commits into from
May 7, 2021

Conversation

amaury1093
Copy link
Contributor

@amaury1093 amaury1093 commented May 4, 2021

Description

some small improvements that I found while auditing x/gov.

ref: #9218


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #9258 (e0fa31f) into master (4af85dc) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9258      +/-   ##
==========================================
+ Coverage   60.28%   60.30%   +0.01%     
==========================================
  Files         591      591              
  Lines       36937    36937              
==========================================
+ Hits        22269    22276       +7     
+ Misses      12698    12691       -7     
  Partials     1970     1970              
Impacted Files Coverage Δ
x/gov/client/cli/tx.go 17.85% <0.00%> (ø)
x/gov/types/proposal.go 19.78% <0.00%> (ø)
x/gov/types/msgs.go 49.03% <0.00%> (+1.92%) ⬆️
x/gov/keeper/deposit.go 76.47% <0.00%> (+5.88%) ⬆️

@github-actions github-actions bot added the T:Docs Changes and features related to documentation. label May 4, 2021
x/gov/spec/01_concepts.md Outdated Show resolved Hide resolved
@amaury1093 amaury1093 requested a review from sunnya97 May 6, 2021 14:35
@amaury1093 amaury1093 marked this pull request as ready for review May 6, 2021 14:35
Copy link
Contributor

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 7, 2021
@mergify mergify bot merged commit 5725659 into master May 7, 2021
@mergify mergify bot deleted the am/9218-gov-audits branch May 7, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/gov T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants