-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/staking v0.43 Audit updates #9267
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9267 +/- ##
=======================================
Coverage 60.32% 60.32%
=======================================
Files 591 591
Lines 36936 36936
=======================================
Hits 22282 22282
Misses 12683 12683
Partials 1971 1971
|
…khita/9218-staking-audit
…khita/9218-staking-audit
…khita/9218-staking-audit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, would like to remove mentions of ServiceMsg (related to #9208)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
…khita/9218-staking-audit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
ref: #9218
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes