Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/staking v0.43 Audit updates #9267

Merged
merged 12 commits into from
May 10, 2021
Merged

x/staking v0.43 Audit updates #9267

merged 12 commits into from
May 10, 2021

Conversation

likhita-809
Copy link
Contributor

@likhita-809 likhita-809 commented May 5, 2021

Description

ref: #9218


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@github-actions github-actions bot added C:CLI C:x/authz C:x/staking T:Docs Changes and features related to documentation. labels May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #9267 (363e87b) into master (9038dfe) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9267   +/-   ##
=======================================
  Coverage   60.32%   60.32%           
=======================================
  Files         591      591           
  Lines       36936    36936           
=======================================
  Hits        22282    22282           
  Misses      12683    12683           
  Partials     1971     1971           
Impacted Files Coverage Δ
x/staking/client/cli/query.go 0.00% <ø> (ø)
x/staking/keeper/grpc_query.go 62.87% <ø> (ø)
x/staking/keeper/msg_server.go 0.45% <ø> (ø)
x/staking/client/testutil/suite.go 99.49% <100.00%> (ø)

@likhita-809 likhita-809 marked this pull request as ready for review May 6, 2021 10:02
@github-actions github-actions bot removed the C:x/authz label May 9, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, would like to remove mentions of ServiceMsg (related to #9208)

x/staking/spec/07_events.md Outdated Show resolved Hide resolved
x/staking/spec/README.md Outdated Show resolved Hide resolved
x/staking/spec/03_messages.md Outdated Show resolved Hide resolved
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 10, 2021
@mergify mergify bot merged commit e96839d into master May 10, 2021
@mergify mergify bot deleted the likhita/9218-staking-audit branch May 10, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Simulations C:x/staking T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants