Move x/feegrant/types to x/feegrant #9273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9273 +/- ##
==========================================
+ Coverage 60.18% 60.20% +0.01%
==========================================
Files 593 591 -2
Lines 37063 37017 -46
==========================================
- Hits 22306 22285 -21
+ Misses 12782 12758 -24
+ Partials 1975 1974 -1
|
blushi
requested review from
technicallyty,
atheeshp,
aleem1314,
amaury1093 and
robert-zaremba
aleem1314
reviewed
May 6, 2021
|
@aleem1314 Done, I've also updated the naming in |
github-actions
bot
added
C:x/auth
T:Docs
aleem1314
approved these changes
May 6, 2021
atheeshp
approved these changes
May 6, 2021
simapp/app.go
Outdated
| feegrantkeeper "github.com/cosmos/cosmos-sdk/x/feegrant/keeper" | ||
| feegranttypes "github.com/cosmos/cosmos-sdk/x/feegrant/types" | ||
| feegrant_m "github.com/cosmos/cosmos-sdk/x/feegrant/module" |
There was a problem hiding this comment.
Is this package name okay? shouldn't we consider feegrantmodule here? I can see a name feegrantkeeper which is similar to this.
There was a problem hiding this comment.
I just wanted to make it consistent with @robert-zaremba's PR on authz updates #9042 but I'm open to change it
There was a problem hiding this comment.
I would vote for feegrantmodule even though it's longer because it's easier to read.
technicallyty
approved these changes
May 6, 2021
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Move x/feegrant/types to x/feegrant * Update spec * Use feegrantmodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #9115
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes