Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for IterateAccounts x/auth keeper meethod #9285

Merged
merged 3 commits into from
May 11, 2021

Conversation

prb-pro
Copy link
Contributor

@prb-pro prb-pro commented May 8, 2021

Description

Update doc for IterateAccounts x/auth keeper method.
Iterator stops when callback returns true instead of false (as stated in documentation)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
    N/A - did not find any open issue for this, seems as small change for opening issue
  • Code follows the module structure standards.
  • Wrote unit and integration tests
    N/A
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
    N/A
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@github-actions github-actions bot added C:x/auth T:Docs Changes and features related to documentation. labels May 8, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label May 10, 2021
@amaury1093
Copy link
Contributor

@l-parabellum could you merge/rebase master so that our automerge bot can merge your PR?

@prb-pro
Copy link
Contributor Author

prb-pro commented May 10, 2021

@l-parabellum could you merge/rebase master so that our automerge bot can merge your PR?

Rebased to master now.

@amaury1093
Copy link
Contributor

@l-parabellum could you actually allow write access to your fork? Or else you'll need to constantly rebase.

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #9285 (a996367) into master (8cfa2c2) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head a996367 differs from pull request most recent head 9b867db. Consider uploading reports for the commit 9b867db to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9285      +/-   ##
==========================================
- Coverage   60.33%   60.30%   -0.03%     
==========================================
  Files         585      591       +6     
  Lines       36789    36937     +148     
==========================================
+ Hits        22195    22276      +81     
- Misses      12624    12691      +67     
  Partials     1970     1970              
Impacted Files Coverage Δ
x/auth/keeper/keeper.go 49.29% <ø> (ø)
x/authz/authorization_grant.go 0.00% <0.00%> (-36.00%) ⬇️
x/authz/simulation/genesis.go 81.81% <0.00%> (-9.10%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 73.91% <0.00%> (-8.70%) ⬇️
crypto/keys/secp256r1/pubkey.go 76.92% <0.00%> (-3.08%) ⬇️
x/authz/msgs.go 53.93% <0.00%> (-3.03%) ⬇️
crypto/keys/secp256r1/privkey.go 80.00% <0.00%> (-2.36%) ⬇️
client/keys/add.go 62.50% <0.00%> (ø)
version/command.go 83.33% <0.00%> (ø)
telemetry/metrics.go 56.86% <0.00%> (ø)
... and 17 more

@prb-pro
Copy link
Contributor Author

prb-pro commented May 11, 2021

@l-parabellum could you actually allow write access to your fork? Or else you'll need to constantly rebase.

Sorry @AmauryM, you should have write access now.

@mergify mergify bot merged commit e79157c into cosmos:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants