Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grpc-web add CORS handler #9493

Merged
merged 12 commits into from
Jun 16, 2021
Merged

feat: grpc-web add CORS handler #9493

merged 12 commits into from
Jun 16, 2021

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Jun 10, 2021

Description

Closes: #9467


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #9493 (ce8691f) into master (3c82a32) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

❗ Current head ce8691f differs from pull request most recent head 78be226. Consider uploading reports for the commit 78be226 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9493      +/-   ##
==========================================
- Coverage   60.59%   60.58%   -0.01%     
==========================================
  Files         589      589              
  Lines       37211    37218       +7     
==========================================
+ Hits        22547    22548       +1     
- Misses      12721    12726       +5     
- Partials     1943     1944       +1     
Impacted Files Coverage Δ
server/config/config.go 41.44% <0.00%> (-0.38%) ⬇️
server/config/toml.go 18.18% <ø> (ø)
server/grpc/grpc_web.go 46.66% <28.57%> (-20.00%) ⬇️

@aleem1314 aleem1314 marked this pull request as ready for review June 11, 2021 04:11
server/grpc/grpc_web.go Outdated Show resolved Hide resolved
server/grpc/grpc_web.go Outdated Show resolved Hide resolved
server/config/config.go Outdated Show resolved Hide resolved
server/config/config.go Outdated Show resolved Hide resolved
server/config/toml.go Outdated Show resolved Hide resolved
aleem1314 and others added 3 commits June 15, 2021 19:12
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@cyberbono3 cyberbono3 self-requested a review June 16, 2021 09:34
Copy link
Contributor

@cyberbono3 cyberbono3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amaury1093
Copy link
Contributor

@aleem1314 did you get a chance to test this manually? I'm okay to merge this if it's tested (or else we need to add another item in regen-network/regen-ledger#352)

@aleem1314
Copy link
Contributor Author

@aleem1314 did you get a chance to test this manually? I'm okay to merge this if it's tested (or else we need to add another item in regen-network/regen-ledger#352)

Yes. I've tested manually. Here is a client if anyone wants to test.

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot @aleem1314! Could you add a changelog entry? Feel free to put automerge right after

@aleem1314 aleem1314 added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 16, 2021
@mergify mergify bot merged commit 38d6702 into master Jun 16, 2021
@mergify mergify bot deleted the aleem/9467-grpcweb-cors branch June 16, 2021 10:33
alexesDev added a commit to p2p-org/p2p-agoric-vstorage-viewer that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CORS handler to grpc-web
5 participants