Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add godocs to GasMeter methods #9665

Merged
merged 9 commits into from
Jul 12, 2021

Conversation

likhita-809
Copy link
Contributor

Description

ref: #9651

This is a follow-up PR of adding godocs to GasMeter methods


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 marked this pull request as ready for review July 9, 2021 15:54
store/types/gas.go Outdated Show resolved Hide resolved
store/types/gas.go Outdated Show resolved Hide resolved
store/types/gas.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #9665 (bfa7536) into master (0027111) will increase coverage by 27.91%.
The diff coverage is 63.61%.

❗ Current head bfa7536 differs from pull request most recent head 61ca6e3. Consider uploading reports for the commit 61ca6e3 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #9665       +/-   ##
===========================================
+ Coverage   35.48%   63.40%   +27.91%     
===========================================
  Files         332      572      +240     
  Lines       32620    37555     +4935     
===========================================
+ Hits        11575    23810    +12235     
+ Misses      19819    11887     -7932     
- Partials     1226     1858      +632     
Impacted Files Coverage Δ
client/keys/types.go 100.00% <ø> (+100.00%) ⬆️
client/query.go 16.98% <ø> (ø)
client/rpc/block.go 0.00% <ø> (ø)
client/rpc/status.go 67.74% <ø> (ø)
client/rpc/validators.go 0.00% <ø> (ø)
client/test_helpers.go 0.00% <ø> (ø)
client/tx/factory.go 27.00% <ø> (ø)
client/tx/legacy.go 68.42% <ø> (ø)
client/tx/tx.go 40.83% <ø> (ø)
client/utils.go 41.93% <ø> (-41.40%) ⬇️
... and 682 more

store/types/gas.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ruhatch ruhatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks - I guess waiting on response to your question!

@alexanderbez alexanderbez added A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation. labels Jul 12, 2021
@cyberbono3 cyberbono3 self-assigned this Jul 12, 2021
@mergify mergify bot merged commit 6997a3c into master Jul 12, 2021
@mergify mergify bot deleted the likhita/add-godocs-to-GasMeter-methods branch July 12, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants