feat!: update Denom regex to support more DID characters

[aaronc]

DID method-specific-ids can include :, ., -, and _ but these are not included in the denom regex. This PR adds them to the regex.

DIDs also support percent encoded hex digits, but these are not added here, but could be included in a separate PR.

/cc @ig-shaun @jandrieu

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[orijbot]

Visit https://dashboard.github.orijtech.com?pr=9699&repo=cosmos%2Fcosmos-sdk to see benchmark details.

[robert-zaremba]

utACK

[aaronc]

@alexanderbez do you see any potential issues here?

[tac0turtle]

LGTM

[ig-shaun]

Thanks @aaronc Great to see this! Supports the path towards a Tokens 2.0 framework for all token types and classes.
It was not clear to me, does this update allow # fragments, which is a common pattern for locating properties within a DID Document?

[amaury1093]

lgtm, can we add a changelog entry?

[aaronc]

Thanks @aaronc Great to see this! Supports the path towards a Tokens 2.0 framework for all token types and classes.
It was not clear to me, does this update allow # fragments, which is a common pattern for locating properties within a DID Document?

Fragments can't be inside a method-specific-id. The only thing left out here is the pct-encoded characters.

[jandrieu]

It was not clear to me, does this update allow # fragments, which is a common pattern for locating properties within a DID Document?

Fragments can't be inside a method-specific-id. The only thing left out here is the pct-encoded characters.

@ig-shaun By convention, URL fragments are handled entirely by the client. The #fragment part does not go to the server with traditional http URLs. The browser simply handles the focus when rendering the html.

However, there is an additional component in the DID world, DID URLs:

The DID URL Syntax ABNF Rules

did-url = did path-abempty [ "?" query ] [ "#" fragment ]

So, DID URLs can have fragments. And, in some cases, a DID URL with a fragment may be used to refer to a particular linked resource (or other property value) in a DID Document.
I believe this is a non-issue if, for example, all DID denoms are pure DIDs and not DID URLs. This feels like a reasonable design choice.

The main adjustment would be an expected practice in any case: instead of blindly resolving a DID URL (sending the whole thing), the resolver can (and probably should) clip the query and fragment parts and treat a DID URL at resolution as if it were just the DID part.

FWIW, the DID Resolver specification is still in early development.

Also--although there are 90+ DID methods and I only know a subset--the only planned use I have heard of for % encoding is for query and fragment parts which is fairly familiar from the Web. For robustness, we should plan on getting that support in, but it's unlikely to be a factor with a normal DID method design.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.