-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: specify staking bond_denom when creating a new chain #9776
feat: specify staking bond_denom when creating a new chain #9776
Conversation
…rn GasLeft on GasMeter
Visit https://dashboard.github.orijtech.com?pr=9776&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
…khita/add-stakingBondDenom-flag-to-init-chain
Codecov Report
@@ Coverage Diff @@
## master #9776 +/- ##
==========================================
- Coverage 63.48% 63.48% -0.01%
==========================================
Files 566 566
Lines 53089 53104 +15
==========================================
+ Hits 33705 33711 +6
- Misses 17477 17485 +8
- Partials 1907 1908 +1
|
…khita/add-stakingBondDenom-flag-to-init-chain
…khita/add-stakingBondDenom-flag-to-init-chain
…khita/add-stakingBondDenom-flag-to-init-chain
…khita/add-stakingBondDenom-flag-to-init-chain
…khita/add-stakingBondDenom-flag-to-init-chain
…khita/add-stakingBondDenom-flag-to-init-chain
…khita/add-stakingBondDenom-flag-to-init-chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@AmauryM any interest in quickly reviewing this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @likhita-809! I'm not sure I like the strings.Replace
, but okay to keep this solution.
I left some comments where I think we could do shorter code.
…khita/add-stakingBondDenom-flag-to-init-chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks better to me, thanks!
Description
Add a flag that allows us to specify staking bond_denom when creating a new chain
ref: #9407
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change