feat: Improve withdraw-all-rewards UX #9781

RiccardoM · 2021-07-27T09:42:17Z

Description

Related to #9489, this PR improves the UX when using the withdraw-all-rewards command by forcing the broadcast mode to block if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (sync and async).

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

… chunk size is not unlimited

alexanderbez

utACK. Can you quickly please explain why block, i.e committed in a block, is needed when chunk > 0? Chunks splits it into multi-msgs, right?

RiccardoM · 2021-07-27T13:34:07Z

utACK. Can you quickly please explain why block, i.e committed in a block, is needed when chunk > 0? Chunks splits it into multi-msgs, right?

Chunking splits the various messages into multiple transactions. If you do not specify the block broadcast mode, when submitting the transactions from the second onward they will all fail due to a wrong account sequence (since it's never updated). If chunks = 0 then a single transaction with many messages will be created while, by default, each tx can contain up to 5 messages.

alexanderbez · 2021-07-27T13:39:03Z

I see. Makes sense. Keep in mind, this is gonna have a poor UX. block mode is NOT encouraged and most likely this command will now fail if say fees or gas is not high enough or if there is high tx block contention.

RiccardoM · 2021-07-27T13:40:29Z

I see. Makes sense. Keep in mind, this is gonna have a poor UX. block mode is NOT encouraged and most likely this command will now fail if say fees or gas is not high enough or if there is high tx block contention.

Then what about making chunk set to 0 if the broadcast mode is not block? Would that be a better UX?

alexanderbez · 2021-07-27T13:43:03Z

Yeah I think so!

…odes

RiccardoM · 2021-07-28T05:39:14Z

@alexanderbez I've changed the implementation to force chunks to be 0 if async or sync are used. I was thinking, maybe it's even better to use 0 as the default value as well?

x/distribution/client/cli/tx.go

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

amaury1093

lgtm, have one question below. Could you also add a changelog entry? For me it's a CLI-breaking change (albeit small one)

amaury1093 · 2021-07-28T09:56:47Z

x/distribution/client/cli/tx.go

+			if clientCtx.BroadcastMode != flags.BroadcastBlock && chunkSize > 0 {
+				cmd.Printf("Cannot use broadcast mode %[1]s with %[2]s != 0. Forcing %[2]s to 0",
+					clientCtx.BroadcastMode, FlagMaxMessagesPerTx)
+				chunkSize = 0


is it worth erroring here? Instead of a bit sliently changing the user inputted flag, as the user might not notice this line.

This will also force the user to add the --FlagMaxMessagesPerTx=0 flag when not using broadcast mode block.

@AmauryM To be honest, I think that would result in a bad UX. As per this comment, the block broadcast mode should be disincentivized, and the sync and async should be used instead. If we require the users to set a flag for the modes sync and async, that might make them simply use the block mode instead. For this reason, I think that changing the value and warning them with that log is sufficient.

Another thing that could be done is simply set the default value of FlagMaxMessagesPerTx to be 0, and error in case async or sync are used and that value is not zero.

Cool. I'm putting automerge on, thanks!

@AmauryM I've swapped the behavior by setting the default chunks to 0 and returning an error when async or sync is used with a FlagMaxMessagesPerTx greater than 0

…thdraw-all-rewards-ux

… into improve-withdraw-all-rewards-ux # Conflicts: # x/distribution/client/cli/tx.go

codecov · 2021-07-28T11:13:50Z

Codecov Report

Merging #9781 (3ebce6f) into master (f4d0682) will decrease coverage by 0.00%.
The diff coverage is 61.27%.

❗ Current head 3ebce6f differs from pull request most recent head ca9e1d5. Consider uploading reports for the commit ca9e1d5 to get more accurate results

@@            Coverage Diff             @@
##           master    #9781      +/-   ##
==========================================
- Coverage   63.47%   63.47%   -0.01%     
==========================================
  Files         566      566              
  Lines       52797    53071     +274     
==========================================
+ Hits        33515    33687     +172     
- Misses      17379    17477      +98     
- Partials     1903     1907       +4

Impacted Files	Coverage Δ
types/events.go	`82.77% <ø> (ø)`
x/distribution/client/cli/tx.go	`4.50% <0.00%> (-0.12%)`	⬇️
x/auth/client/cli/query.go	`2.15% <6.41%> (+2.15%)`	⬆️
x/auth/ante/sigverify.go	`68.07% <38.00%> (-5.86%)`	⬇️
crypto/keys/internal/ecdsa/privkey.go	`84.21% <88.00%> (+2.39%)`	⬆️
crypto/keys/internal/ecdsa/pubkey.go	`77.08% <100.00%> (+9.43%)`	⬆️
x/auth/client/testutil/suite.go	`96.31% <100.00%> (+0.40%)`	⬆️

orijbot · 2021-07-28T11:58:43Z

Visit https://dashboard.github.orijtech.com?pr=9781&repo=cosmos%2Fcosmos-sdk to see benchmark details.

(cherry picked from commit 90157fc)

tac0turtle · 2021-07-28T12:47:14Z

Not sure we want this as block may be moved to only be used for testing, as was the original intention.

EDIT: whoops nevermind. Read the code.

RiccardoM · 2021-07-30T14:55:42Z

Can we have this in the next 0.42.x release @robert-zaremba?

robert-zaremba · 2021-07-30T21:34:10Z

We released 0.42.8 earlier today. I think we can add it to the next 0.42 release - it's only CLI breaking.

We will definitely cherry pick it to 0.43

## Description Related to #9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 90157fc) # Conflicts: # CHANGELOG.md

* feat: Improve withdraw-all-rewards UX (#9781) ## Description Related to #9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 90157fc) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch>

* feat: Improve withdraw-all-rewards UX (#9781) ## Description Related to #9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 90157fc) # Conflicts: # CHANGELOG.md * Fix conflict Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch>

RiccardoM · 2021-08-04T10:39:38Z

@AmauryM Can you please add this to v0.42.9 as well?

…9825) * feat: Improve withdraw-all-rewards UX (cosmos#9781) ## Description Related to cosmos#9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 90157fc) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch>

robert-zaremba · 2021-08-04T12:47:41Z

It's already added. We are making a release today.

…9824) * feat: Improve withdraw-all-rewards UX (cosmos#9781) ## Description Related to cosmos#9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 90157fc) # Conflicts: # CHANGELOG.md * Fix conflict Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch>

@jleni

* docs: add v0.43 release version option (backport cosmos#9506) (cosmos#9677) * docs: add v0.43 version option (cosmos#9506) Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com> (cherry picked from commit 325dabd) # Conflicts: # docs/versions * fix conflicts Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * chore: Add missing entry in 0.42.7 Changelog (cosmos#9722) * fix: support output flag on tx commands (backport cosmos#9717) (cosmos#9772) * fix: support output flag on tx commands (cosmos#9717)  ## Description Closes: cosmos#9684  * feat: Query txs by signature and by address+seq (backport cosmos#9750) (cosmos#9783) * feat: Query txs by signature and by address+seq (cosmos#9750)  ## Description Closes: cosmos#9741  * fix: hardcoded ledger algo on `keys add` (backport cosmos#9766) (cosmos#9804) * fix: hardcoded ledger algo on `keys add` (cosmos#9766)  ## Description Closes: cosmos#9734 cc: @jleni  * chore: Add Changelog and Release Notes for v0.42.8 (cosmos#9807) * chore: Add Changelog and Release Notes for v0.42.8 * Change date * feat: Improve withdraw-all-rewards UX (backport cosmos#9781) (cosmos#9825) * feat: Improve withdraw-all-rewards UX (cosmos#9781) ## Description Related to cosmos#9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). * fix: Capability Issue on Restart, Backport to v0.42 (cosmos#9835) * implement BeginBlock fix * add changelog * fix lint * address reviews * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * address reviews * Apply suggestions from code review Co-authored-by: Robert Zaremba <robert@zaremba.ch> * move store check * add api breaking changelog * fix lint Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Fixed the --recover flag not working properly inside the init command (cosmos#9201) (cosmos#9850) Co-authored-by: Alessio Treglia <alessio@tendermint.com> (cherry picked from commit fdbc32e) Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * chore: prepare 0.42.9 release (cosmos#9852) * prepare 0.42.9 release * add 9201 to changelog Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> Co-authored-by: Aditya <adityasripal@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

…9824) * feat: Improve withdraw-all-rewards UX (cosmos#9781) Related to cosmos#9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 90157fc) * Fix conflict Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch>

…9824) * feat: Improve withdraw-all-rewards UX (cosmos#9781) ## Description Related to cosmos#9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 90157fc) # Conflicts: # CHANGELOG.md * Fix conflict Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch>

Improved withdraw-all-rewards UX by forcing BroadcastMode to block if…

adc8a83

… chunk size is not unlimited

RiccardoM requested review from aaronc and alexanderbez as code owners July 27, 2021 09:42

github-actions bot added C:CLI C:x/distribution distribution module related labels Jul 27, 2021

Updated command documentation

5a69de4

RiccardoM mentioned this pull request Jul 27, 2021

x/distribution withdraw-all-rewards got wrong account sequence on PeriodicVestingAccount desmos-labs/desmos#567

Closed

alexanderbez approved these changes Jul 27, 2021

View reviewed changes

RiccardoM added 2 commits July 28, 2021 07:36

Updated how to handle withdraw-all-rewards with different broadcast m…

3d7f6b8

…odes

Merge branch 'master' into improve-withdraw-all-rewards-ux

94cacd2

amaury1093 reviewed Jul 28, 2021

View reviewed changes

x/distribution/client/cli/tx.go Outdated Show resolved Hide resolved

Update x/distribution/client/cli/tx.go

3ebce6f

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

amaury1093 approved these changes Jul 28, 2021

View reviewed changes

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 28, 2021

RiccardoM added 3 commits July 28, 2021 12:41

Merge branch 'master' of github.com:cosmos/cosmos-sdk into improve-wi…

b66e6ed

…thdraw-all-rewards-ux

Added CHANGELOG entry

5a40a2c

Merge remote-tracking branch 'desmos/improve-withdraw-all-rewards-ux'…

ca9e1d5

… into improve-withdraw-all-rewards-ux # Conflicts: # x/distribution/client/cli/tx.go

mergify bot merged commit 90157fc into cosmos:master Jul 28, 2021

RiccardoM deleted the improve-withdraw-all-rewards-ux branch July 28, 2021 12:00

RiccardoM added a commit to desmos-labs/cosmos-sdk that referenced this pull request Jul 28, 2021

feat: Improve withdraw-all-rewards UX (cosmos#9781)

ed657dc

(cherry picked from commit 90157fc)

robert-zaremba added the backport/0.43.x label Jul 30, 2021

mergify bot mentioned this pull request Jul 30, 2021

feat: Improve withdraw-all-rewards UX (backport #9781) #9824

Merged

robert-zaremba added the backport/0.42.x (Stargate) label Jul 30, 2021

mergify bot mentioned this pull request Jul 30, 2021

feat: Improve withdraw-all-rewards UX (backport #9781) #9825

Merged

fedekunze mentioned this pull request Nov 14, 2021

all: cherry pick olympus mons tharsis/cosmos-sdk#1

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Improve withdraw-all-rewards UX #9781

feat: Improve withdraw-all-rewards UX #9781

RiccardoM commented Jul 27, 2021 •

edited

Loading

alexanderbez left a comment

RiccardoM commented Jul 27, 2021 •

edited

Loading

alexanderbez commented Jul 27, 2021

RiccardoM commented Jul 27, 2021

alexanderbez commented Jul 27, 2021

RiccardoM commented Jul 28, 2021

amaury1093 left a comment •

edited

Loading

amaury1093 Jul 28, 2021 •

edited

Loading

RiccardoM Jul 28, 2021

amaury1093 Jul 28, 2021

RiccardoM Jul 28, 2021 •

edited

Loading

codecov bot commented Jul 28, 2021

orijbot commented Jul 28, 2021

tac0turtle commented Jul 28, 2021 •

edited

Loading

RiccardoM commented Jul 30, 2021

robert-zaremba commented Jul 30, 2021

RiccardoM commented Aug 4, 2021

robert-zaremba commented Aug 4, 2021

feat: Improve withdraw-all-rewards UX #9781

feat: Improve withdraw-all-rewards UX #9781

Conversation

RiccardoM commented Jul 27, 2021 • edited Loading

Description

Author Checklist

Reviewers Checklist

alexanderbez left a comment

Choose a reason for hiding this comment

RiccardoM commented Jul 27, 2021 • edited Loading

alexanderbez commented Jul 27, 2021

RiccardoM commented Jul 27, 2021

alexanderbez commented Jul 27, 2021

RiccardoM commented Jul 28, 2021

amaury1093 left a comment • edited Loading

Choose a reason for hiding this comment

amaury1093 Jul 28, 2021 • edited Loading

Choose a reason for hiding this comment

RiccardoM Jul 28, 2021

Choose a reason for hiding this comment

amaury1093 Jul 28, 2021

Choose a reason for hiding this comment

RiccardoM Jul 28, 2021 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jul 28, 2021

Codecov Report

orijbot commented Jul 28, 2021

tac0turtle commented Jul 28, 2021 • edited Loading

RiccardoM commented Jul 30, 2021

robert-zaremba commented Jul 30, 2021

RiccardoM commented Aug 4, 2021

robert-zaremba commented Aug 4, 2021

RiccardoM commented Jul 27, 2021 •

edited

Loading

RiccardoM commented Jul 27, 2021 •

edited

Loading

amaury1093 left a comment •

edited

Loading

amaury1093 Jul 28, 2021 •

edited

Loading

RiccardoM Jul 28, 2021 •

edited

Loading

tac0turtle commented Jul 28, 2021 •

edited

Loading