-
Notifications
You must be signed in to change notification settings - Fork 160
circleCI config and linting fixes #3
Conversation
ansermino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update golang version (1.12+ I think?) and working directory in cirlceci config.
Working on getting CricleCI setup 👍
Of course! I quickly did this change so I didn't even notice the go version, thanks for that catch. I updated the config, let me know if you think this will be good for the work we are doing. I included the building of the Daemon and cli because this will be implemented soon and also split the jobs into tools/build and tests since they are independent |
|
Looks great! The sdk is using I've contacted CircleCI support regarding out access issues. |
|
@ansermino @GregTheGreek I have finished the commits I think are necessary if you could review. I have left some unused variables as commented out as I'm not sure if they will be needed in the future (let me get your opinion on if you think they should be deleted instead) |
GregTheGreek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious about a few things otherwise LGTM
…dns-packet-1.3.4 build(deps): bump dns-packet from 1.3.1 to 1.3.4 in /docs
Sets up CI to be run for whenever circleCI gets enabled for this fork.
Verifying the dependencies makefile command had changed which was being run by the ci and also I fixed the linter warnings that were preexisting.