Skip to content
This repository was archived by the owner on Nov 30, 2021. It is now read-only.

Conversation

@austinabell
Copy link

Sets up CI to be run for whenever circleCI gets enabled for this fork.

Verifying the dependencies makefile command had changed which was being run by the ci and also I fixed the linter warnings that were preexisting.

@austinabell austinabell changed the title Fixed circleci config and fixed linting warnings circleCI config and linting fixes Jun 26, 2019
Copy link

@ansermino ansermino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update golang version (1.12+ I think?) and working directory in cirlceci config.

Working on getting CricleCI setup 👍

@austinabell
Copy link
Author

Please update golang version (1.12+ I think?) and working directory in cirlceci config.

Working on getting CricleCI setup 👍

Of course! I quickly did this change so I didn't even notice the go version, thanks for that catch. I updated the config, let me know if you think this will be good for the work we are doing. I included the building of the Daemon and cli because this will be implemented soon and also split the jobs into tools/build and tests since they are independent

@ansermino
Copy link

Looks great! The sdk is using go 1.12.5, so lets do the same (afaik putting 1.12 will pull 1.12.0).

I've contacted CircleCI support regarding out access issues.

@austinabell
Copy link
Author

@ansermino @GregTheGreek I have finished the commits I think are necessary if you could review. I have left some unused variables as commented out as I'm not sure if they will be needed in the future (let me get your opinion on if you think they should be deleted instead)

@austinabell austinabell requested a review from GregTheGreek July 2, 2019 18:43
Copy link

@GregTheGreek GregTheGreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious about a few things otherwise LGTM

@austinabell austinabell merged commit 69333ec into master Jul 2, 2019
@austinabell austinabell deleted the austin/ciupdate branch July 3, 2019 15:23
faddat added a commit to faddat/ethermint-1 that referenced this pull request Jun 5, 2021
…dns-packet-1.3.4

build(deps): bump dns-packet from 1.3.1 to 1.3.4 in /docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants