fix errors and make testnet work #403

araskachoi · 2020-07-21T20:01:11Z

changed alpine -> ubuntu (to make binaries work)
changed a few lines for docker image names in make file

Closes: #XXX

Description

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Dockerfile

fedekunze · 2020-07-22T07:56:00Z

@araskachoi can you pull the latest changes from the testnet branch? 🙏 Works for me at least but it'd be great if we could get an ACK from @J-Thompson12 and @noot too 👍

noot · 2020-07-22T14:49:37Z

looks good to me!

Creating network "ethermint_localnet" with driver "bridge"
Creating emintdnode3 ... done
Creating emintdnode2 ... done
Creating emintdnode1 ... done
Creating emintdnode0 ... done

at this point, are the nodes up/ am I able to query them?

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

…tnet

…-testnet

fedekunze · 2020-07-23T07:32:08Z

Makefile

-	docker cp $${container_id}:/usr/bin/emintd ./build/ ; \
-	docker cp $${container_id}:/usr/bin/emintcli ./build/


so this copyies the binaries to the build folder, which allows the ./build:/emintd:Z volumes to be mounted.

is it necessary for the binary to be copied over to the directory? Why don't we have the binary just be built into the image directly?

This is how i do that:
https://github.com/ChainSafe/ethermint/blob/fix-testnet/Dockerfile#L25-L26

fedekunze · 2020-07-23T07:33:28Z

Makefile

-	if ! [ -f build/node0/$(ETHERMINT_DAEMON_BINARY)/config/genesis.json ]; then docker run --rm -v $(CURDIR)/build:/$(ETHERMINT_DAEMON_BINARY):Z emintd/node testnet --v 4 -o . --starting-ip-address 192.168.10.2 --keyring-backend=test ; fi
+	docker container start $${container_id} ;
+
+	if ! [ -f build/node0/$(ETHERMINT_DAEMON_BINARY)/config/genesis.json ]; then docker run --rm -v $(CURDIR)/build:/ethermint:Z ethermint-build-linux "emintd testnet --v 4 -o ethermint --starting-ip-address 192.168.10.2 --keyring-backend=test"; fi


$(CURDIR)/build:/ethermint:Z

I don't think the ethermint directory exists

the directory is mounted to the volume on your local machine ($CURDIR/build) and the ethermint dir is created when mounted

fedekunze · 2020-07-23T07:34:32Z

docker-compose.yml

@@ -3,63 +3,67 @@ version: "3"
 services:
  emintdnode0:
    container_name: emintdnode0
-    image: "emintd/node"


I'd suggest keeping the image names as they are now to isolate the changes

sure, but we would need to change it everywhere on the makefile as well, that can be an easy change

fedekunze · 2020-07-23T07:36:20Z

Dockerfile

@@ -28,4 +28,4 @@ COPY --from=build-env /go/src/github.com/ChainSafe/ethermint/build/emintcli /usr
 EXPOSE 26656 26657 1317

 # Run emintd by default, omit entrypoint to ease using container with emintcli
-CMD ["emintd"]
+ENTRYPOINT ["/bin/bash", "-c"]


I don't understand the diff here with CMD ["emintd"] can you add a code comment?

CMD is used when there are no args passed the the docker run command (i.e. docker run <image>). We pass args like testnets [flags] ...` so we would need entrypoint.

this might be a better explanation
https://stackoverflow.com/a/44201230

fedekunze · 2020-07-23T07:37:02Z

Dockerfile

+FROM golang:1.14 as final

-# Install ca-certificates
-RUN apk add --update ca-certificates
-WORKDIR /root
+WORKDIR /
+
+RUN apt-get update


correct me if I'm wrong but this change should be the only one made in order to make this work for all the OS?

well all this does is allow the binaries created from the previous build step (build-env) to be executable on the final image

araskachoi · 2020-07-27T20:31:17Z

@fedekunze done, spins up emintd and emintcli in bg and logs to respective files (emintd.log, emintcli.log)

@J-Thompson12 @noot can you guys try again to get the local net up?

noot · 2020-07-28T01:16:04Z

@araskachoi i see this:

Creating network "ethermint_localnet" with driver "bridge"
Creating emintdnode1 ... done
Creating emintdnode3 ... done
Creating emintdnode0 ... done
Creating emintdnode2 ... done

there's no logs, is that expected?

araskachoi · 2020-07-28T01:39:56Z

@araskachoi i see this:

Creating network "ethermint_localnet" with driver "bridge"
Creating emintdnode1 ... done
Creating emintdnode3 ... done
Creating emintdnode0 ... done
Creating emintdnode2 ... done

there's no logs, is that expected?

Yep, that should be expected. had to redirect output to make the daemon into a background process (to run rcp server too). If you want to check and see the logs of the nodes, you can do this:
docker exec emintdnode0 tail emintd.log

fedekunze · 2020-07-29T13:40:19Z

@araskachoi I still get the address book message when initializing the nodes. Is that expected?

If you want to check and see the logs of the nodes, you can do this:
docker exec emintdnode0 tail emintd.log

Can you update the docs (docs/quickstart/testnet.md) and add an instruction for that? 🙏

araskachoi · 2020-07-29T16:18:32Z

@araskachoi I still get the address book message when initializing the nodes. Is that expected?

yikes.. i forgot to check that. if it is still showing, it should be an issue that isnt related to the rpc. however, now the rpc servers are spun up and can be queriable! Should be fine as long as the blocks are synchronized and no errors regarding dialing the peers. We should maybe make this as a todo to change that to some sort of WARN level or something?

Can you update the docs (docs/quickstart/testnet.md) and add an instruction for that? 🙏

👍 will do!

* evm: fix non-determinism * fixes * typo * fix tests * local testnet command * fix testnet cmd (#383) fix export-eth-key generate eth type account in genesis.json file * fixes * update docker * minor changes * fix build-docker-local-ethermint * fix dockerfile * update Makefile * update denoms * update genesis file * update makefile * fix docker-compose.yml images * fix localnet execution (#398) * finish documentation * changelog and comment rpc tests workflow * update codecov * update testnet docs * fix docker-compose execution * update docs * fix errors and make testnet work (#403) * fix errors and make testnet work * Update Dockerfile Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * wip - fix db * fixes emintd nodes and syncs nodes * starts daemon and rpc server in bg Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze <federico.kunze94@gmail.com> * update entrypoint and docs * update logs * try fix rpc * build docker image * Update Dockerfile Co-authored-by: Holechain <nrgh@foxmail.com> Co-authored-by: Alessio Treglia <quadrispro@ubuntu.com> Co-authored-by: Daniel Choi <choidanielw@gmail.com>

fix errors and make testnet work

ff244e8

araskachoi requested review from fedekunze and noot as code owners July 21, 2020 20:01

fedekunze reviewed Jul 22, 2020

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

araskachoi and others added 5 commits July 22, 2020 08:46

Update Dockerfile

dc2a24d

Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>

Merge branch 'testnet' of github.com:ChainSafe/ethermint into fix-tes…

2195678

…tnet

Merge branch 'testnet' of github.com:ChainSafe/ethermint into fix-tes…

a40139d

…tnet

Merge branch 'fix-testnet' of github.com:ChainSafe/ethermint into fix…

84bd101

…-testnet

wip - fix db

5123cc3

fedekunze reviewed Jul 23, 2020

View reviewed changes

araskachoi added 2 commits July 27, 2020 13:27

fixes emintd nodes and syncs nodes

acb6f6c

starts daemon and rpc server in bg

90f9ecc

fedekunze approved these changes Jul 29, 2020

View reviewed changes

fedekunze merged commit a9983c3 into testnet Jul 29, 2020

fedekunze deleted the fix-testnet branch July 29, 2020 17:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix errors and make testnet work #403

fix errors and make testnet work #403

araskachoi commented Jul 21, 2020

fedekunze commented Jul 22, 2020 •

edited

Loading

noot commented Jul 22, 2020

fedekunze Jul 23, 2020

araskachoi Jul 23, 2020

fedekunze Jul 23, 2020

araskachoi Jul 23, 2020

fedekunze Jul 23, 2020

araskachoi Jul 23, 2020

fedekunze Jul 23, 2020

araskachoi Jul 23, 2020 •

edited

Loading

fedekunze Jul 23, 2020

araskachoi Jul 23, 2020

araskachoi commented Jul 27, 2020

noot commented Jul 28, 2020

araskachoi commented Jul 28, 2020

fedekunze commented Jul 29, 2020

araskachoi commented Jul 29, 2020

		docker cp $${container_id}:/usr/bin/emintd ./build/ ; \
		docker cp $${container_id}:/usr/bin/emintcli ./build/

fix errors and make testnet work #403

fix errors and make testnet work #403

Conversation

araskachoi commented Jul 21, 2020

Description

fedekunze commented Jul 22, 2020 • edited Loading

noot commented Jul 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

araskachoi Jul 23, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

araskachoi commented Jul 27, 2020

noot commented Jul 28, 2020

araskachoi commented Jul 28, 2020

fedekunze commented Jul 29, 2020

araskachoi commented Jul 29, 2020

fedekunze commented Jul 22, 2020 •

edited

Loading

araskachoi Jul 23, 2020 •

edited

Loading