Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Geth benchmarking #417

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Geth benchmarking #417

merged 1 commit into from
Jul 30, 2020

Conversation

J-Thompson12
Copy link
Contributor

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

# i dont know what the windows command would be to get the last created account thats what this does in windows
for /f "delims=" %%i in ('geth --datadir "data" account list') do set account=%%i
./benchmarking ag -ac %account% -am 10000000
# echo "Generated test$i account"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just kinda guessed on these commands to hope they work on mac. Bash scripts suck no matter what on windows so some of these will need fixed.

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #417 into benchmark will increase coverage by 12.14%.
The diff coverage is 86.02%.

Impacted file tree graph

@@              Coverage Diff               @@
##           benchmark     #417       +/-   ##
==============================================
+ Coverage      55.71%   67.85%   +12.14%     
==============================================
  Files             35       33        -2     
  Lines           2353     2380       +27     
==============================================
+ Hits            1311     1615      +304     
+ Misses           930      641      -289     
- Partials         112      124       +12     
Impacted Files Coverage Δ
x/evm/genesis.go 67.44% <50.00%> (ø)
x/evm/keeper/querier.go 71.22% <50.00%> (+11.51%) ⬆️
x/evm/types/journal.go 86.27% <72.97%> (+48.77%) ⬆️
x/evm/types/state_object.go 85.71% <83.78%> (+26.07%) ⬆️
x/evm/types/statedb.go 81.44% <90.00%> (+17.51%) ⬆️
app/ante/eth.go 62.91% <100.00%> (ø)
x/evm/types/genesis.go 100.00% <100.00%> (ø)
x/evm/types/storage.go 100.00% <100.00%> (ø)
types/account.go
types/codec.go
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef24a09...afba2db. Read the comment docs.

@araskachoi araskachoi merged commit 62fb328 into benchmark Jul 30, 2020
@araskachoi araskachoi deleted the justin/bench branch July 30, 2020 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants