Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

evm: params #458

Merged
merged 32 commits into from
Sep 2, 2020
Merged

evm: params #458

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
46ae305
evm: params
fedekunze Aug 18, 2020
3bd141b
setup
fedekunze Aug 18, 2020
72fc40e
bump commit
fedekunze Aug 18, 2020
7d041d7
fixes
fedekunze Aug 18, 2020
7b4e423
increase gas usage
fedekunze Aug 18, 2020
6fa8e29
tests
fedekunze Aug 18, 2020
2338725
conflicts
fedekunze Aug 31, 2020
9ffd1e8
evm denom param
fedekunze Sep 1, 2020
452cc78
more config updates
fedekunze Sep 1, 2020
8269746
update genesis
fedekunze Sep 1, 2020
39048af
update ante handler
fedekunze Sep 1, 2020
2289f34
csdb param test
fedekunze Sep 1, 2020
2a364e7
more tests and fixes
fedekunze Sep 1, 2020
fa83504
update statedb.Copy
fedekunze Sep 1, 2020
ab18272
lint
fedekunze Sep 1, 2020
c7c89ab
additional test
fedekunze Sep 1, 2020
d1c1e0a
fix importer tests
fedekunze Sep 1, 2020
d267cc3
fix AnteHandler test
fedekunze Sep 1, 2020
7fe95ba
minor update
fedekunze Sep 1, 2020
94adf0f
revert
fedekunze Sep 1, 2020
86dbdb5
undo gas update
fedekunze Sep 1, 2020
64957ac
stringer test
fedekunze Sep 1, 2020
7c09c23
changelog
fedekunze Sep 1, 2020
8fa07a8
fix csdb index error (#493)
noot Sep 1, 2020
5b9e443
Merge branch 'development' into evm-params
fedekunze Sep 2, 2020
c01ca51
Merge branch 'development' of github.com:ChainSafe/ethermint into evm…
fedekunze Sep 2, 2020
ff3e6b4
Merge branch 'evm-params' of github.com:ChainSafe/ethermint into evm-…
fedekunze Sep 2, 2020
7958be1
update default hash
fedekunze Sep 2, 2020
6fd7af7
update querier
fedekunze Sep 2, 2020
0ec092d
update rpc tests
fedekunze Sep 2, 2020
e5d1736
updates from development
fedekunze Sep 2, 2020
1b8a25b
fix estimate gas test
noot Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/rpc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,11 +754,11 @@ func TestEth_EstimateGas(t *testing.T) {
require.NotNil(t, rpcRes)
require.NotEmpty(t, rpcRes.Result)

var gas hexutil.Bytes
var gas string
err := json.Unmarshal(rpcRes.Result, &gas)
require.NoError(t, err, string(rpcRes.Result))

require.Equal(t, "0xffdf", gas.String())
require.Equal(t, "0x1051d", gas)
Copy link
Contributor Author

@fedekunze fedekunze Sep 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we should address this? technically it should remain the same? @noot

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it should likely be the same, do we have any tests for actual gas consumption vs estimation? if not we should add some

}

func TestEth_EstimateGas_ContractDeployment(t *testing.T) {
Expand Down