Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

fix default account addr prefix #472

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

happlins
Copy link

Description

The default cosmos prefix is still used instead of the eth prefix set through config.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@CLAassistant
Copy link

CLAassistant commented Aug 25, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #472 into development will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #472   +/-   ##
============================================
  Coverage        69.92%   69.92%           
============================================
  Files               38       38           
  Lines             2487     2487           
============================================
  Hits              1739     1739           
  Misses             617      617           
  Partials           131      131           
Impacted Files Coverage Δ
x/evm/client/cli/utils.go 74.07% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98610e4...5734087. Read the comment docs.

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @2016-huanglins

@fedekunze fedekunze merged commit b3c895d into cosmos:development Aug 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants