Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

change photon to aphoton #476

Merged
merged 6 commits into from
Aug 31, 2020
Merged

change photon to aphoton #476

merged 6 commits into from
Aug 31, 2020

Conversation

J-Thompson12
Copy link
Contributor

@J-Thompson12 J-Thompson12 commented Aug 27, 2020

Closes: https://github.com/ChainSafe/ethermint/issues/434

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (development@a6e152b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #476   +/-   ##
==============================================
  Coverage               ?   69.99%           
==============================================
  Files                  ?       38           
  Lines                  ?     2493           
  Branches               ?        0           
==============================================
  Hits                   ?     1745           
  Misses                 ?      617           
  Partials               ?      131           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e152b...04d7af2. Read the comment docs.

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you add new doc under docs/basics/photon.md that says that the base denomination of Ethermint is the atto Photon to maintain parity Ethereum (and add the conversion formula from the issue). 🙏

docs/guides/metamask.md Outdated Show resolved Hide resolved
docs/guides/metamask.md Outdated Show resolved Hide resolved
@fedekunze
Copy link
Contributor

here's a photon token image for the docs too:
image

@fedekunze fedekunze merged commit 4344dc1 into development Aug 31, 2020
@fedekunze fedekunze deleted the aphoton branch August 31, 2020 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Photon base denom unit precision
2 participants