Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

fix secp256k1 public key formatting #501

Merged
merged 3 commits into from
Sep 7, 2020
Merged

Conversation

noot
Copy link
Contributor

@noot noot commented Sep 4, 2020

Closes: #XXX

Description

use CompressPubkey and DecompressPubkey instead of FromECDSAPub and UnmarshalPubkey, fixes bech32 encoding error


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@noot noot requested a review from fedekunze as a code owner September 4, 2020 20:49
@noot noot self-assigned this Sep 4, 2020
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #501 into account-pretty will decrease coverage by 0.10%.
The diff coverage is 42.85%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           account-pretty     #501      +/-   ##
==================================================
- Coverage           71.82%   71.72%   -0.11%     
==================================================
  Files                  40       40              
  Lines                2673     2677       +4     
==================================================
  Hits                 1920     1920              
- Misses                614      616       +2     
- Partials              139      141       +2     
Impacted Files Coverage Δ
crypto/secp256k1.go 74.35% <42.85%> (-8.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0b4145...feb4bec. Read the comment docs.

@fedekunze fedekunze merged commit 5fc2d2d into account-pretty Sep 7, 2020
@fedekunze fedekunze deleted the noot/fix-keys branch September 7, 2020 12:45
fedekunze added a commit that referenced this pull request Sep 7, 2020
* types: update account pubkey JSON to string

* changelog

* Update app/ethermint.go

* tests

* update

* fix secp256k1 public key formatting (#501)

* use Compress and Decompress pubkey for secp256k1 keys

* cleanup

* update estimate gas test

* comments

Co-authored-by: noot <36753753+noot@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants