This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
account balance fix #507
Merged
account balance fix #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #507 +/- ##
===============================================
+ Coverage 71.94% 72.43% +0.49%
===============================================
Files 41 41
Lines 2709 2714 +5
===============================================
+ Hits 1949 1966 +17
+ Misses 619 606 -13
- Partials 141 142 +1
Continue to review full report at Codecov.
|
noot
approved these changes
Sep 9, 2020
| case diff.IsNegative(): | ||
| // Decrease coins to amount | ||
| coins = coins.Sub(sdk.NewCoins(NewPhotonCoin(diff.Neg()))) | ||
| coins = coins.Sub(sdk.NewCoins(sdk.NewCoin(denom, diff.Neg()))) |
There was a problem hiding this comment.
is the sdk.NewCoins necessary here? the add case doesn't have it
There was a problem hiding this comment.
yeah, idk the reason of the inconsistency on the SDK. The Add function has a spread parameter while the Sub doesn't
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)