This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
evm: module specification #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #538 +/- ##
============================================
Coverage 70.71% 70.71%
============================================
Files 42 42
Lines 2339 2339
============================================
Hits 1654 1654
Misses 541 541
Partials 144 144
Continue to review full report at Codecov.
|
noot
reviewed
Dec 8, 2020
| hash := req.Header.LastBlockId.GetHash() | ||
| height := req.Header.GetHeight() - 1 | ||
|
|
||
| k.SetHeightHash(ctx, uint64(height), common.BytesToHash(hash)) |
There was a problem hiding this comment.
why is this no longer in EndBlock?
There was a problem hiding this comment.
because the values won't be exported so there's no need to add it on the end block
noot
reviewed
Dec 9, 2020
noot
reviewed
Dec 9, 2020
araskachoi
reviewed
Dec 9, 2020
noot
reviewed
Dec 9, 2020
x/evm/spec/07_params.md
Outdated
| * `stateObject`: to track the `evm_denom` balance of the object account. | ||
| * `CommitStateDB`: to update account balance from an existing state object. | ||
|
|
||
| For example, on Ethereum, the `evm_denom` would be `ETH`. In the case of Ethermint, the default denomination is the atto photon. |
There was a problem hiding this comment.
maybe add that 1photon = 10^18 attophoton, making it equivalent to eth and wei?
noot
approved these changes
Dec 9, 2020
summerpro
reviewed
Dec 10, 2020
| height := req.Header.GetHeight() - 1 | ||
|
|
||
| k.SetHeightHash(ctx, uint64(height), common.BytesToHash(hash)) | ||
| k.SetBlockHash(ctx, hash, height) |
There was a problem hiding this comment.
Why not combine SetHeightHash and SetBlockHash into one function?
fedekunze
added a commit
that referenced
this pull request
Dec 14, 2020
* deps: update to cosmos-sdk v0.39.2-rc3 (#608) * update to cosmos-sdk v0.39.2 * fix HD path test * changelog (#609) * build: require go 1.15+ (#610) * evm: state transitions enabled params (#603) * changelog * evm: state transitions enabled params * changelog entry * changelog * deps: bump cosmos-sdk version to v0.39.2 (#615) * deps: bump cosmos-sdk version to v0.39.2 * changelog * rpc: fix deadlock (#614) * update tools configs (#611) * update tools configs * minor updates * add jq (#616) * build(deps): bump gopkg.in/yaml.v2 from 2.3.0 to 2.4.0 (#622) Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.3.0 to 2.4.0. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](go-yaml/yaml@v2.3.0...v2.4.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * app: fix export genesis (#619) * v0.3.1 changes * fix export genesis * changelog * evm: fix genesis format mismatch (#623) * evm: fix genesis format mismatch * genesis tests * fix test * changelog * nolint * force build-ethermint and cleanup stdout (#628) Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * join network doc (#606) * join network doc * include faucet instructions * add rpc instructions * edit persistent peers * update to latest testnet * evm: implement vm.GetHashFn (#620) * evm: implement vm.GetHashFn * check nil case * test * handle 3 cases * use switch statement * stateDB tests * abci changes * fix LGTM issue * final tests * changelog * remove epoch * update test * clean test * rm epoch * open Istanbul and MuirGlacier from ChainConfig (#645) * open Istanbul and MuirGlacier * fix ut * fix ut * evm: extra eips param (#643) * evm: extra eips param * changelog * rpc: protocol version (#575) * evm: protocol version * changelog * version * fix * support latest version only * evm: module specification (#538) * evm: module specification * params and events * readme and messages * minor updates * concepts * genesis state concept * begin and end block * update parameters and genesis * state objects * state table * use permalink * init and export genesis * update abci * extra eips param * review comments * precision * link to photon doc * build(deps): bump gaurav-nelson/github-action-markdown-link-check (#649) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.8 to 1.0.9. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.8...7481451) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * stargate: fix conflicts * more fixes * proto changes * more tendermint changes * test fixes * atlas: evm module (#651) * atlas: evm module * typos * update toml * update description * Update x/evm/atlas/atlas-v0.3.1.md * Update x/evm/atlas/atlas-v0.3.1.md Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * build(deps): bump actions/setup-node from v2.1.2 to v2.1.3 (#653) Bumps [actions/setup-node](https://github.com/actions/setup-node) from v2.1.2 to v2.1.3. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v2.1.2...27082ce) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/ethereum/go-ethereum from 1.9.24 to 1.9.25 (#654) * build(deps): bump github.com/ethereum/go-ethereum from 1.9.24 to 1.9.25 Bumps [github.com/ethereum/go-ethereum](https://github.com/ethereum/go-ethereum) from 1.9.24 to 1.9.25. - [Release notes](https://github.com/ethereum/go-ethereum/releases) - [Commits](ethereum/go-ethereum@v1.9.24...v1.9.25) Signed-off-by: dependabot[bot] <support@github.com> * fixes Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze <federico.kunze94@gmail.com> * build(deps): bump gaurav-nelson/github-action-markdown-link-check (#652) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.9 to 1.0.10. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.9...72d871b) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * update peers (#656) * update peers * update chainid in cmd * build(deps): bump gaurav-nelson/github-action-markdown-link-check (#659) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.10 to 1.0.11. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.10...2a60e0f) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump ini from 1.3.5 to 1.3.8 in /docs (#658) Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Daniel Choi <choidanielw@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Pierre <974741468@qq.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.