This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
update chain-id format #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## development #542 +/- ##
===============================================
- Coverage 70.77% 70.72% -0.06%
===============================================
Files 41 42 +1
Lines 2320 2333 +13
===============================================
+ Hits 1642 1650 +8
- Misses 536 540 +4
- Partials 142 143 +1
Continue to review full report at Codecov.
|
fedekunze
commented
Sep 24, 2020
| @@ -57,6 +61,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
|
|
|||
| * (ante) [\#525](https://github.com/ChainSafe/ethermint/pull/525) Add message validation decorator to `AnteHandler` for `MsgEthereumTx`. | |||
| * (types) [\#507](https://github.com/ChainSafe/ethermint/pull/507) Fix hardcoded `aphoton` on `EthAccount` balance getter and setter. | |||
| * (types) [\#501](https://github.com/ChainSafe/ethermint/pull/501) Fix bech32 encoding error by using the compressed ethereum secp256k1 public key. | |||
There was a problem hiding this comment.
forgot to add this bug changelog entry
fedekunze
commented
Sep 24, 2020
| run: | | ||
| make test-sim-multi-seed-short | ||
| if: "env.GIT_DIFF != ''" | ||
| # install-runsim: |
There was a problem hiding this comment.
commented them because they are currently broken anyway
noot
approved these changes
Sep 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #540
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)