Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

rpc, evm: refactor #588

Merged
merged 12 commits into from
Oct 22, 2020
Merged

rpc, evm: refactor #588

merged 12 commits into from
Oct 22, 2020

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Oct 22, 2020 •
edited
Loading

  • The rpc package has been refactored to account for the separation of each corresponding Ethereum API namespace:
    • rpc/namespaces/eth: eth namespace. Exposes the PublicEthereumAPI and the PublicFilterAPI.
    • rpc/namespaces/personal: personal namespace. Exposes the PrivateAccountAPI.
    • rpc/namespaces/net: net namespace. Exposes the PublicNetAPI.
    • rpc/namespaces/web3: web3 namespace. Exposes the PublicWeb3API.
  • The EVM transaction CLI has been removed in favor of the JSON-RPC.

@lgtm-com
Copy link

lgtm-com bot commented Oct 22, 2020

This pull request introduces 1 alert when merging ab687e5 into be09a6e - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Oct 22, 2020

This pull request introduces 1 alert when merging 47f9d90 into be09a6e - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@fedekunze fedekunze changed the title fedekunze/stargate refactor rpc, evm: refactor Oct 22, 2020
@fedekunze fedekunze marked this pull request as ready for review October 22, 2020 16:33
@fedekunze fedekunze requested a review from noot as a code owner October 22, 2020 16:33
@fedekunze fedekunze requested a review from araskachoi October 22, 2020 16:34
@fedekunze fedekunze added rpc Ethereum JSON-RPC related issues and PRs Type: Maintenance labels Oct 22, 2020
noot
noot reviewed Oct 22, 2020
View reviewed changes
rpc/doc.go Outdated Show resolved Hide resolved
noot
noot approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, nice cleanup!

@fedekunze fedekunze merged commit 4501bbc into development Oct 22, 2020
@fedekunze fedekunze deleted the fedekunze/stargate-refactor branch October 22, 2020 20:39
@freddyli7 freddyli7 mentioned this pull request May 11, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noot noot noot approved these changes

@araskachoi araskachoi araskachoi approved these changes

Assignees
No one assigned
Labels
rpc Ethereum JSON-RPC related issues and PRs Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedekunze @araskachoi @noot