Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Fix mis-calculate block hash in evm related method #755

Merged
merged 4 commits into from
Feb 1, 2021
Merged

Fix mis-calculate block hash in evm related method #755

merged 4 commits into from
Feb 1, 2021

Conversation

louisliu2048
Copy link

@louisliu2048 louisliu2048 commented Jan 28, 2021

Closes #721 and closes #751

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@louisliu2048
Copy link
Author

According to my observation, as long as you update the CHANGELOG.md file, the following step will always fail:
image
Maybe this check method should be update and remove something related to CHANGELOG.md git diff.

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect calculate blockchain hash in evm rpc module Mismatch Block Hash in RPC Response
2 participants