Skip to content

Conversation

@dongsam
Copy link
Contributor

@dongsam dongsam commented May 7, 2025

Description

This PR addresses minor fixes that were missing from the IBC v2 integration PR conducted at #95

  • Fixed missing parts and updated test cases related to the ERC20 prefix changes
  • Applied remaining updates for the change from denomTrace to denom introduced in IBC v9 and rebuilt contracts
  • Minor updates to comments and function names

Other solhint ci fix


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@dongsam dongsam force-pushed the fix-ibc-v2-follow-up branch from b51d377 to e11d1e8 Compare May 7, 2025 06:25
@dongsam dongsam marked this pull request as ready for review May 7, 2025 07:22
Copy link
Contributor

@zsystm zsystm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@cloudgray cloudgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vladjdk vladjdk merged commit 3075d9f into cosmos:main May 7, 2025
17 checks passed
zsystm pushed a commit to zsystm/evm that referenced this pull request Nov 2, 2025
* fix: follow-up fix for ibc v2 feature

* build: add explicit solhint version for constant ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants