Fix compile issue in start.go #179
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
reviewed
May 23, 2025
| @@ -145,10 +145,6 @@ which accepts a path for the resulting pprof file. | |||
| } | |||
|
|
|||
| serverCtx.Logger.Debug("received quit signal") | |||
| // TODO: why is this check here? Should not make sense since err is checked above | |||
There was a problem hiding this comment.
why is this check here? doesnt make sense since the error is checked above. can likely remove it
Eric-Warehime
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
start.goTesting
go fmt server/start.gogo build ./server...(fails: proxyconnect tcp: no route to host)