-
Notifications
You must be signed in to change notification settings - Fork 131
feat: set no-op router to EvidenceKeeper for evmd #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When calling submitEvidence through hardhat(ethers.js), type conversion from args[1] into Equivocation doesn't work.
vladjdk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, let's think about a permanent fix or whether we should remove the Evidence precompile entirely. @aljo242 pinging you here for visibility.
|
@vladjdk cc: @cloudgray |
* add default router for evidence keeper * fix type handling When calling submitEvidence through hardhat(ethers.js), type conversion from args[1] into Equivocation doesn't work. * fix lint * enable evidence precompile at local_node.sh * implement no-op evidence handler * remove un-used code --------- Co-authored-by: Vlad J <vladjdk@gmail.com>
Description
This PR sets an empty evidencetypes.Router to the EvidenceKeeper when constructing the reference evmd app.
Context
The
evmdapp aims to support all precompiles as a reference implementation. However, the current setup lacks a router configuration forEvidenceKeeper, which causes a nil panic when invokingSubmitEvidencefrom the evidence precompile.Moreover, the Evidence precompile isn't even enabled in
local_node.shby default, meaning it's not currently part of the standard local testing flow.Even if we add the Evidence precompile to the runtime, it cannot function properly without a router set in EvidenceKeeper, making any E2E flow impossible at the moment.
Fix
local_node.shnoOpEvidenceHandlerand assigns it to theEvidenceKeeperinapp.go. This allows theSubmitEvidenceto be executed without panic and enables E2E testing for the evidence flow.Closes: #275
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleasedsection inCHANGELOG.md