Skip to content

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Jul 23, 2025

Description

  • adjusts GasTipCap to equal GasFeeCap when it exceeds max fee cap for evm transfer
  • ensures adequate fees for bank msg send

Closes: #338


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code
  • reviewed content
  • tested instructions (if applicable)
  • confirmed all CI checks have passed

@mmsqe mmsqe requested review from a team as code owners July 23, 2025 14:23
@mmsqe mmsqe changed the title test: adjusts GasTipCap to equal GasFeeCap when it exceeds the max fee cap test: avoid invalid gas cap & fee rounding error in BenchmarkAnteHandler Jul 23, 2025
Copy link
Contributor

@cloudgray cloudgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vladjdk vladjdk enabled auto-merge August 5, 2025 20:51
@vladjdk vladjdk added this pull request to the merge queue Aug 5, 2025
Merged via the queue into cosmos:main with commit 138fe5d Aug 5, 2025
16 checks passed
zsystm pushed a commit to zsystm/evm that referenced this pull request Nov 2, 2025
…ler (cosmos#345)

* test: adjusts GasTipCap to equal GasFeeCap when it exceeds the maximum fee cap

* ensures adequate fees for bank msg send

---------

Co-authored-by: Vlad J <vladjdk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: BenchmarkAnteHandler fails - invalid gas cap & fee rounding error

3 participants