feat: add convert coin endpoint #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Joel Smith <joelsmith.2019@gmail.com>
Contributor
Eric-Warehime
left a comment
Eric-Warehime
left a comment
There was a problem hiding this comment.
Probably need tests around the new keeper method and the message validation.
Co-authored-by: Eric Warehime <eric.warehime@gmail.com>
nowooj
reviewed
Apr 21, 2025
| // ConvertCoin mints a ERC20 token representation of the native Cosmos coin | ||
| // that is registered on the token mapping. | ||
| rpc ConvertCoin(MsgConvertCoin) returns (MsgConvertCoinResponse) { | ||
| option (google.api.http).get = "/cosmos/evm/erc20/v1/tx/convert_coin"; |
There was a problem hiding this comment.
In what cases is this gateway endpoint used?
It's a bit confusing because it's msg_server and not query.
Member
Author
There was a problem hiding this comment.
It converts a coin from a bank token to an ERC20.
Eric-Warehime
approved these changes
May 8, 2025
zsystm
pushed a commit
to zsystm/evm
that referenced
this pull request
Nov 2, 2025
* feat(erc20): add convert coin endpoint Co-Authored-By: Joel Smith <joelsmith.2019@gmail.com> * lints * Update proto/cosmos/evm/erc20/v1/tx.proto Co-authored-by: Eric Warehime <eric.warehime@gmail.com> * return error on negative amount * NewMsgConvertCoin * add negative error * msg validation testing * keeper call testing * lints --------- Co-authored-by: Reece Williams <reecepbcups@gmail.com> Co-authored-by: Joel Smith <joelsmith.2019@gmail.com> Co-authored-by: Eric Warehime <eric.warehime@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #17
reopens: #36