Merge remote-tracking branch 'origin/main' into faddat/errors

cosmos · Jun 14, 2023 · 66e9456 · 66e9456
2 parents 0e44315 + dd332fb
commit 66e9456
Show file tree

Hide file tree

Showing 107 changed files with 3,724 additions and 838 deletions.
diff --git a/.github/ISSUE_TEMPLATE/epic-template.md b/.github/ISSUE_TEMPLATE/epic-template.md
@@ -4,20 +4,20 @@ about: Basic template for EPICs (used by the team)
 labels: epic, needs-triage
 ---
 
-# Problem
+## Problem
 
 <!-- Please write a concise 1-3 line problem. -->
 
-# Closing criteria
+## Closing criteria
 
 <!-- Please write a satisfiable criteria for closing this issue. -->
 
 
-# Problem details
+## Problem details
 
 <!-- Please describe the problem in all detail. -->
 
-# Task list
+## Task list
 
 ```[tasklist]
 ### Must have

diff --git a/.github/ISSUE_TEMPLATE/feature-request.md b/.github/ISSUE_TEMPLATE/feature-request.md
@@ -1,7 +1,7 @@
 ---
 name: Feature Request
 about: Create a proposal to request a feature
-labels: enhancement, needs-triage
+labels: enhancement, epic, needs-triage
 ---
 
 <!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ 
@@ -26,6 +26,19 @@ Are there any disadvantages of including this feature? -->
 
 <!-- Detailed description of requirements of implementation -->
 
+## Task list
+
+```[tasklist]
+### Must have
+- [ ] discuss proposal (if proposal rejected, close EPIC)
+- [ ] create ADR (if ADR rejected, close EPIC)
+- [ ] add sub-tasks needed to implement the proposed feature
+```
+
+```[tasklist]
+### Nice to have
+- [ ] add sub-tasks that are nice to have for the proposed feature
+```
 ____
 
 #### For Admin Use

diff --git a/.github/ISSUE_TEMPLATE/issue-template.md b/.github/ISSUE_TEMPLATE/issue-template.md
@@ -1,7 +1,7 @@
 ---
 name: Issue Template
 about: Basic template for issues (used by the team)
-
+labels: needs-triage
 ---
 
 <!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ 

diff --git a/.github/ISSUE_TEMPLATE/upgrade-checklist.md b/.github/ISSUE_TEMPLATE/upgrade-checklist.md
@@ -6,7 +6,7 @@ labels: epic, needs-triage
 
 ## Cosmos Hub Upgrade Epic
 
-# <Upgrade Name>
+### <Upgrade Name>
 
 **Create an issue for each item** and mark complete once it has been done.
 

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,51 +1,5 @@
-<!--
-The default pull request template is for types feat, fix, or refactor.
-For other templates, add one of the following parameters to the url:
-- template=docs.md
-- template=other.md
--->
+Please go the the `Preview` tab and select the appropriate sub-template:
 
-## Description
-
-Closes: #XXXX
-
-<!-- Add a description of the changes that this PR introduces and the files that
-are the most critical to review. -->
-
-<!-- Pull requests that sit inactive for longer than 14 days will be closed.  -->
-
----
-
-### Author Checklist
-
-*All items are required. Please add a note to the item if the item is not applicable and
-please add links to any relevant follow up issues.*
-
-I have...
-
-* [ ] Included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
-* [ ] Added `!` to the type prefix if API or client breaking change
-* [ ] Targeted the correct branch (see [PR Targeting](https://github.com/cosmos/gaia/blob/main/CONTRIBUTING.md#pr-targeting))
-* [ ] Provided a link to the relevant issue or specification
-* [ ] Followed the guidelines for [building SDK modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
-* [ ] Included the necessary unit and integration [tests](https://github.com/cosmos/gaia/blob/main/CONTRIBUTING.md#testing)
-* [ ] Added a changelog entry to `CHANGELOG.md`
-* [ ] Included comments for [documenting Go code](https://blog.golang.org/godoc)
-* [ ] Updated the relevant documentation or specification
-* [ ] Reviewed "Files changed" and left comments if necessary <!-- relevant if the changes are not obvious  -->
-* [ ] Confirmed all CI checks have passed
-
-### Reviewers Checklist
-
-*All items are required. Please add a note if the item is not applicable and please add
-your handle next to the items reviewed if you only reviewed selected items.*
-
-I have...
-
-* [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
-* [ ] confirmed `!` in the type prefix if API or client breaking change
-* [ ] confirmed all author checklist items have been addressed 
-* [ ] reviewed state machine logic
-* [ ] reviewed API design and naming
-* [ ] reviewed documentation is accurate
-* [ ] reviewed tests and test coverage
+* [Production code](?expand=1&template=production.md) - for types `fix`, `feat`, and `refactor`.
+* [Docs](?expand=1&template=docs.md) - for documentation changes.
+* [Others](?expand=1&template=others.md) - for changes that do not affect production code.
diff --git a/.github/PULL_REQUEST_TEMPLATE/production.md b/.github/PULL_REQUEST_TEMPLATE/production.md
@@ -0,0 +1,48 @@
+<!--
+The production pull request template is for types feat, fix, or refactor.
+-->
+
+## Description
+
+Closes: #XXXX
+
+<!-- Add a description of the changes that this PR introduces and the files that
+are the most critical to review. -->
+
+<!-- Pull requests that sit inactive for longer than 14 days will be closed.  -->
+
+---
+
+### Author Checklist
+
+*All items are required. Please add a note to the item if the item is not applicable and
+please add links to any relevant follow up issues.*
+
+I have...
+
+* [ ] Included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
+* [ ] Added `!` to the type prefix if API or client breaking change
+* [ ] Targeted the correct branch (see [PR Targeting](https://github.com/cosmos/gaia/blob/main/CONTRIBUTING.md#pr-targeting))
+* [ ] Provided a link to the relevant issue or specification
+* [ ] Followed the guidelines for [building SDK modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules)
+* [ ] Included the necessary unit and integration [tests](https://github.com/cosmos/gaia/blob/main/CONTRIBUTING.md#testing)
+* [ ] Added a changelog entry to `CHANGELOG.md`
+* [ ] Included comments for [documenting Go code](https://blog.golang.org/godoc)
+* [ ] Updated the relevant documentation or specification
+* [ ] Reviewed "Files changed" and left comments if necessary <!-- relevant if the changes are not obvious  -->
+* [ ] Confirmed all CI checks have passed
+
+### Reviewers Checklist
+
+*All items are required. Please add a note if the item is not applicable and please add
+your handle next to the items reviewed if you only reviewed selected items.*
+
+I have...
+
+* [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
+* [ ] confirmed `!` in the type prefix if API or client breaking change
+* [ ] confirmed all author checklist items have been addressed 
+* [ ] reviewed state machine logic
+* [ ] reviewed API design and naming
+* [ ] reviewed documentation is accurate
+* [ ] reviewed tests and test coverage
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -21,7 +21,7 @@ updates:
     directory: "/"
     schedule:
       interval: daily
-    target-branch: "release/v9.0.x"
+    target-branch: "release/v10.0.x"
     # Only allow automated security-related dependency updates on release branches.
     open-pull-requests-limit: 0
     labels:
@@ -31,7 +31,7 @@ updates:
     directory: "/"
     schedule:
       interval: daily
-    target-branch: "release/v8.0.x"
+    target-branch: "release/v9.1.x"
     # Only allow automated security-related dependency updates on release branches.
     open-pull-requests-limit: 0
     labels:

diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml
@@ -1,26 +1,16 @@
-# For most projects, this workflow file will not need changing; you simply need
-# to commit it to your repository.
-#
-# You may wish to alter this file to override the set of languages analyzed,
-# or to provide custom queries or build logic.
-#
-# ******** NOTE ********
-# We have attempted to detect the languages in your repository. Please check
-# the `language` matrix defined below to confirm you have the correct set of
-# supported CodeQL languages.
-#
 name: "CodeQL"
 
 on:
-  push:
-    branches: [ main, rc/v*, release/v* ]
   pull_request:
-    # The branches below must be a subset of the branches above
-    branches: [ main ]
-    paths-ignore:
-      - "**/*.md"
-  schedule:
-    - cron: '0 * * * *'
+    paths:
+      - "**.go"
+  push:
+    branches:
+      - main
+      - release/v*
+      - feat/**
+    paths:
+      - "**.go"
 
 jobs:
   analyze:
@@ -31,26 +21,25 @@ jobs:
       contents: read
       security-events: write
 
-    strategy:
-      fail-fast: false
-      matrix:
-        language: [ 'go' ]
-        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
-        # Learn more about CodeQL language support at https://git.io/codeql-language-support
-
     steps:
     - name: Checkout repository
       uses: actions/checkout@v3.5.2
-
-    # Initializes the CodeQL tools for scanning.
+    - uses: actions/setup-go@v4
+      with:
+        go-version: "1.20"
+        check-latest: true
+
+   # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v2
       with:
-        languages: ${{ matrix.language }}
+        languages: "go"
         # If you wish to specify custom queries, you can do so here or in a config file.
         # By default, queries listed here will override any specified in a config file.
         # Prefix the list here with "+" to use these queries and those in the config file.
         # queries: ./path/to/local/query, your-org/your-repo/queries@main
+        queries: +security-and-quality,github/codeql/go/ql/src/experimental/InconsistentCode/DeferInLoop.ql@main,github/codeql/go/ql/src/experimental/Unsafe/WrongUsageOfUnsafe.ql@main,github/codeql/go/ql/src/experimental/CWE-369/DivideByZero.ql@main
+        packs: +crypto-com/cosmos-sdk-codeql
 
     # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
     # If this step fails, then you should remove it and run the build manually (see below)

diff --git a/.github/workflows/docker-push.yml b/.github/workflows/docker-push.yml
@@ -21,28 +21,28 @@ jobs:
         uses: actions/checkout@v3.5.2
 
       - name: Log in to the Container registry
-        uses: docker/login-action@v2.1.0
+        uses: docker/login-action@v2.2.0
         with:
           registry: ${{ env.REGISTRY }}
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Extract metadata (tags, labels) for Docker
         id: meta
-        uses: docker/metadata-action@v4.4.0
+        uses: docker/metadata-action@v4.5.0
         with:
           images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
 
       - name: Build and push Docker image
-        uses: docker/build-push-action@v4.0.0
+        uses: docker/build-push-action@v4.1.0
         with:
           context: .
           push: true
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
 
       - name: Build and push e2e docker image
-        uses: docker/build-push-action@v4.0.0
+        uses: docker/build-push-action@v4.1.0
         with:
           context: .
           file: Dockerfile.e2e

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -24,7 +24,7 @@ jobs:
           make build-docs LEDGER_ENABLED=false
 
       - name: Deploy 🚀
-        uses: JamesIves/github-pages-deploy-action@v4.4.0
+        uses: JamesIves/github-pages-deploy-action@v4.4.2
         with:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           BRANCH: gh-pages

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -1,26 +1,33 @@
-name: golangci-lint
+name: Lint
 on:
   push:
-    tags:
-      - v*
     branches:
       - main
+      - release/**
+      - feat/**
   pull_request:
 permissions:
   contents: read
-  # Optional: allow read access to pull request. Use with `only-new-issues` option.
-  # pull-requests: read
 jobs:
   golangci:
-    name: lint
+    name: golangci-lint
     runs-on: ubuntu-latest
     steps:
+      - uses: actions/checkout@v3.5.2
       - uses: actions/setup-go@v4
         with:
-          go-version: 1.20.x
-      - uses: actions/checkout@v3.5.2
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3
+          go-version: "1.20"
+          check-latest: true
+      - uses: technote-space/get-diff-action@v6.1.2
+        id: git_diff
         with:
-          # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
-          version: v1.52.2
+          PATTERNS: |
+            **/*.go
+            go.mod
+            go.sum
+            **/go.mod
+            **/go.sum
+      - name: run linting
+        if: env.GIT_DIFF
+        run: |
+          make lint
diff --git a/.github/workflows/linkchecker.yml → .github/workflows/md-link-checker.yml b/.github/workflows/linkchecker.yml → .github/workflows/md-link-checker.yml
@@ -1,10 +1,12 @@
 name: Check Markdown links
-on: push
+on: 
+  schedule: 
+    - cron: '* */24 * * *'
 jobs:
   markdown-link-check:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3.5.2
-      - uses: gaurav-nelson/github-action-markdown-link-check@1.0.13
+      - uses: actions/checkout@v3
+      - uses: gaurav-nelson/github-action-markdown-link-check@1.0.15
         with:
-          folder-path: "docs"
+          folder-path: "docs"