Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum Commission for proposal 76 #1697

Closed
5 tasks
MiB-Intern opened this issue Aug 26, 2022 · 2 comments
Closed
5 tasks

Minimum Commission for proposal 76 #1697

MiB-Intern opened this issue Aug 26, 2022 · 2 comments

Comments

@MiB-Intern
Copy link

Summary

If proposal 76 passes, validator min commission should be enforced onchain.

Problem Definition

Right now MsgEditValidator and MsgCreateValidator allow any commission value, we should check that c.Rate is above the amount decided by governance.

Proposal

  • Write AnteHandle for minimum commission check
  • Write Upgrade Handler for validator commission update

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@MiB-Intern MiB-Intern mentioned this issue Aug 26, 2022
Closed
@mmulji-ic
Copy link
Contributor

mmulji-ic commented Aug 30, 2022 •
edited
Loading

Prop #76 end-date: 2022-09-08

@okwme
Copy link
Contributor

okwme commented Sep 12, 2022

closing as this proposal failed

@okwme okwme closed this as completed Sep 12, 2022
@brianmori brianmori mentioned this issue Oct 21, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: implement ante handle for min commission kintsugi-tech/gaia
3 participants
@okwme @mmulji-ic @MiB-Intern