Minimum Commission for proposal 826

[brianmori]

Summary

The proposal 826 has passed. The validator minimum commission should be enforced onchain.

Problem Definition

The MsgEditValidator and MsgCreateValidator allow any commission value. It should have a min value of 5%.
An existing issue was raised time ago: #1697

Proposal

An existing PR was developed in the past. Resolves #1698

Task list

Must have

Beta Give feedback

1. discuss proposal (if proposal rejected, close EPIC)
2. create ADR (if ADR rejected, close EPIC)
3. add sub-tasks needed to implement the proposed feature

Nice to have

Beta Give feedback

1. add sub-tasks that are nice to have for the proposed feature

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned
• Is a spike necessary to map out how the issue should be approached?

[mmulji-ic]

Thanks @brianmori for the reminder and linking in the original PR. We try to get this merged for the next release.

[mpoke]

Due to the timeline of the next release (i.e., a proposal of v14.0.0 is expected to be submitted on the Hub by Nov 17), this feature will go into Gaia v15. Since we want to avoid releases around the winter holidays, v15 is scheduled for January 2024. Also, v15 will most likely update SDK to 0.47, which enables setting the minimum commission through a gov param. Therefore, in v15 we'll just set the default of this param to 5%.

Note though that just setting the param to 5% will not change the commission of existing validators. The param affects only the MsgEditValidator and MsgCreateValidator messages. To enforce the existing validators to have a minimum commission, migration code needs to be written.

[toschdev]

It's not so complicated actually

https://github.com/CosmosContracts/juno/pull/81/files