Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Gov mediated ICA E2E Test #1746

Closed
5 tasks
Tracked by #2413 ...
okwme opened this issue Sep 15, 2022 · 5 comments · Fixed by #1843
Closed
5 tasks
Tracked by #2413 ...

Create Gov mediated ICA E2E Test #1746

okwme opened this issue Sep 15, 2022 · 5 comments · Fixed by #1843
Assignees
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.

Comments

@okwme
Copy link
Contributor

okwme commented Sep 15, 2022

Summary

Problem Definition

Once icamauth is in main we will be able to test the entire user flow of creating and controlling an interchain account using the new gov module. The current gov E2E and the current icamauth E2E do not contain this flow.

We should make a new E2E test that focuses on the goveranance use case of interchain accounts.

Proposal

Outline the exact flow based on @hxrts input.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@hxrts
Copy link
Contributor

hxrts commented Sep 15, 2022

Happy path for Cosmos Hub swapping tokens on Osmosis and moving them back to its own community pool.

  1. arbitrary message proposal: create interchain account for the cosmos hub gov module on osmosis
  2. community spend proposal: 1000 ATOM, local gov module is recipient
  3. arbitrary (multi) message proposal: IBC send from local gov module to remote interchain account address on osmosis + ICA exchange message to desired pool with size, slippage, etc.
  4. arbitrary message proposal: ICA IBC transfer from remote ICA account back to the hub community pool

steps 2 and 3 can be combined in the next release of the cosmos sdk with bez's community pool/gov refactor cosmos/cosmos-sdk#12852

@okwme
Copy link
Contributor Author

okwme commented Nov 15, 2022

blocked on cosmos sdk release v0.46.5

@mpoke mpoke added the more-info-needed Further information is requested label Jan 26, 2023
@mpoke
Copy link
Contributor

mpoke commented Jan 26, 2023

@mmulji-ic Is this still relevant?

@mpoke mpoke added this to the Improve QA process milestone Jan 27, 2023
@mpoke mpoke removed this from the Improve QA process milestone Mar 5, 2023
@mpoke mpoke added the status: waiting-triage This issue/PR has not yet been triaged by the team. label Mar 6, 2023
@mpoke mpoke added this to Cosmos Hub Mar 9, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Mar 9, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Mar 9, 2023
@mpoke mpoke removed more-info-needed Further information is requested status: waiting-triage This issue/PR has not yet been triaged by the team. labels Mar 9, 2023
@mpoke mpoke added the scope: testing Code review, testing, making sure the code is following the specification. label Mar 9, 2023
@mpoke
Copy link
Contributor

mpoke commented Mar 9, 2023

Delayed until we upgrade to SDK 0.47

@mpoke mpoke moved this from 📥 Todo to 🛑 Blocked in Cosmos Hub Mar 9, 2023
@mpoke mpoke added the S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth label Sep 14, 2023
@sainoe sainoe self-assigned this Sep 19, 2023
@sainoe sainoe moved this from 🛑 F3: OnHold to 📥 F2: Todo in Cosmos Hub Sep 19, 2023
@sainoe sainoe moved this from 📥 F2: Todo to 🏗 F3: InProgress in Cosmos Hub Sep 22, 2023
@sainoe sainoe moved this from 🏗 F3: InProgress to 🛑 F3: OnHold in Cosmos Hub Sep 25, 2023
@sainoe
Copy link
Contributor

sainoe commented Sep 26, 2023

closed in favour of #2539.

@sainoe sainoe closed this as completed Sep 26, 2023
@github-project-automation github-project-automation bot moved this from 🛑 F3: OnHold to 👍 F4: Assessment in Cosmos Hub Sep 26, 2023
@mpoke mpoke moved this from 👍 F4: Assessment to ✅ Done in Cosmos Hub Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Productivity Productivity: Developer tooling, infrastructure improvements enabling future growth scope: testing Code review, testing, making sure the code is following the specification.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants