feat(e2e): manage ica from gov module #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## target-v0-46 #1843 +/- ##
===============================================
Coverage ? 76.81%
===============================================
Files ? 34
Lines ? 1889
Branches ? 0
===============================================
Hits ? 1451
Misses ? 375
Partials ? 63 |
Pantani
changed the title
Pantani
changed the title
# Conflicts: # tests/e2e/e2e_gov_test.go # tests/e2e/e2e_setup_test.go # tests/e2e/e2e_test.go
okwme
reviewed
Nov 2, 2022
okwme
reviewed
Nov 2, 2022
| numberOfEvidences = 10 | ||
| slashingShares int64 = 10000 | ||
| ) | ||
|
|
||
| const ( | ||
| // genesis accounts enum | ||
| icaOwnerAccountIndex = iota + 1 |
There was a problem hiding this comment.
ooo i didn't know about this : )
# Conflicts: # go.work.sum
# Conflicts: # tests/e2e/e2e_ibc_test.go # tests/e2e/e2e_ica_test.go # tests/e2e/e2e_test.go
Pantani
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
cmwaters,
jackzampolin,
mmulji-ic and
glnro
as code owners
yaruwangway
reviewed
Nov 22, 2022
yaruwangway
approved these changes
Dec 14, 2022
okwme
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1746