Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Updates for upstream PR (community pool spend proposal) #10

Merged
merged 16 commits into from
May 21, 2019
Merged

R4R: Updates for upstream PR (community pool spend proposal) #10

merged 16 commits into from
May 21, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented May 20, 2019 •
edited
Loading

Ref cosmos/cosmos-sdk#4329

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@cwgoes cwgoes added type: feature-request New feature or request improvement ready-for-review labels May 20, 2019
@cwgoes cwgoes mentioned this pull request May 20, 2019
Merged
5 tasks
@cwgoes
Copy link
Contributor Author

cwgoes commented May 20, 2019

I think test_cover is broken for unrelated reasons, and make check doesn't seem to run the CLI tests.

@alexanderbez alexanderbez added the status: blocked Blocked by an external issue. label May 20, 2019
@alexanderbez
Copy link
Contributor

Fixed master @cwgoes. Not sure if you need to rebase (on the SDK) or not.

@alexanderbez
Copy link
Contributor

Blocked on the approval/merge of cosmos/cosmos-sdk#4329.

@cwgoes cwgoes removed the status: blocked Blocked by an external issue. label May 21, 2019
@cwgoes cwgoes changed the title R4R: Updates for upstream PR R4R: Updates for upstream PR (community pool spend proposal) May 21, 2019
@cwgoes cwgoes requested a review from sabau May 21, 2019 10:09
alessio
alessio reviewed May 21, 2019
View reviewed changes
cmd/gaiacli/main.go Outdated Show resolved Hide resolved
alessio
alessio suggested changes May 21, 2019
View reviewed changes
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment. Integration tests are failing too

@cwgoes cwgoes requested a review from alessio May 21, 2019 12:41
@alessio alessio merged commit 5c5bf7c into master May 21, 2019
@alessio alessio deleted the cwgoes/proposal-7 branch May 21, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio alessio approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
type: feature-request New feature or request improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwgoes @alexanderbez @alessio