Fix error handling and fix linting

[faddat]

This pr:

Fixes linting, we used obsolete linters.
Fixes linting, we had a diff check in place that made PR's to other versions of gaia fail by default because we would run the linters on the
diffs.
Fixes error handling in export.go, we did not check errors.

I'll now take those same changes and apply to v6.0.5 and since it won't run linters on diffs we won't have errors. I honestly figured that the hub maintainers were aware of this.

[codecov]

Codecov Report

Merging #1507 (441d7e9) into main (bc15e65) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
- Coverage   48.05%   47.86%   -0.20%     
==========================================
  Files          10       10              
  Lines        1494     1498       +4     
==========================================
- Hits          718      717       -1     
- Misses        755      760       +5     
  Partials       21       21              

[faddat]

Oh, and the codecov report?

total red herring

this pr definitely improves gaia.

[okwme]

Hi @faddat thank you for the PR.
Can you clarify further, my understanding of the use of diff was so that we don't run linters on code that already had linters running on it.
you're saying that the diff setting is not having this effect and is instead resulting in linters being run on incomplete code and therefore incorrectly failing?
In general I would like to change our CI so that linting is not unnecessarily run since every PR takes so long to pass tests, even when the changes are just markdown files.

[faddat]

Yes, if we use that diff thingy for linting, we do not end up linting historical code, and if we continue to use the diff thingy it causes matienance issues on older gaias. As explained in #1449 -- the diff doodad it'll work if we've just got one release we're maintaining and otherwise it ... it is a straight path to not-good-times.

#1449

golangci-lint does not add any significant time to the ci runs.

It is run in parallel with the other linters, and since it is slower than the slow ones, is nbd.

[faddat]

codecov is a red herring factory, see #1449

[faddat]

Odd thing about response times.

#1577

[faddat]

this is just getting silly.

I've been elected to validate the hub by my delegators.

Validators are supposed to check through the code.

I found that we were behind where we should be, linting-wise.

I solved that.

What is going on here guys?

Please don't lock this PR, it is the appropriate place for this conversation.

This is a security-enhancing PR from May 26. It is July 10.

If you do not wish my contributions to hit this repository, I understand but I need for the cosmos hub team lead, @okwme to say that so that I can inform my delegators.

[tac0turtle]

Lgtm. Let's keep the scope of prs small. Can we spin out the action changes to a different pr please

[faddat]

sure thing

[faddat]

I've removed github actions changes from this PR.

[okwme]

thanks for the pr @faddat and thank you for the review @marbar3778
merging now