Okwme/e2e updates #1652
Closed
Okwme/e2e updates #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwme
requested review from
alexanderbez,
zmanian,
yaruwangway,
jgimeno,
crodriguezvega,
cmwaters and
jackzampolin
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1652 +/- ##
=======================================
Coverage 47.88% 47.88%
=======================================
Files 10 10
Lines 1489 1489
=======================================
Hits 713 713
Misses 755 755
Partials 21 21 |
|
Hi @okwme , does this pr contain refactor ? if yes, can we remove the refactor part ? and leave refactor todo when all open e2e pr merged .. otherwise, too much conflicts. |
|
@yaruwangway good idea! |
|
marked as draft until then @yaruwangway |
|
thanks ! |
5 tasks
yaruwangway
reviewed
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the e2e to address the failing upgrade proposal test that was removed in #1625