Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merge After Upgrade] Cleanup in preparation of new docs #183

Merged
merged 9 commits into from
Dec 11, 2019

Conversation

gamarin2
Copy link
Contributor

@gamarin2 gamarin2 commented Nov 4, 2019

DO NOT MERGE BEFORE HUB SUCCESSFULLY UPGRADES

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@fedekunze
Copy link
Collaborator

@gamarin2 is this R4R ?

@gamarin2 gamarin2 marked this pull request as ready for review December 9, 2019 16:56
@gamarin2 gamarin2 changed the title Cleanup in preparation of new docs [Merge After Upgrade] Cleanup in preparation of new docs Dec 9, 2019
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #183 into master will decrease coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   65.63%   65.24%   -0.39%     
==========================================
  Files           5        5              
  Lines         515      515              
==========================================
- Hits          338      336       -2     
- Misses        146      148       +2     
  Partials       31       31
Impacted Files Coverage Δ
lcd_test/helpers.go 75.53% <0%> (-0.72%) ⬇️

@fedekunze fedekunze merged commit 495feec into master Dec 11, 2019
@fedekunze fedekunze deleted the gamarin/cleanup branch December 11, 2019 15:50
mmulji-ic added a commit that referenced this pull request Jan 26, 2024
Updated deployment scripts, aligning with ICS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants