feat: Add command bech32-convert #1845

ivanovpetr · 2022-10-25T09:54:30Z

This PR is adding the gaiad debug bech32-convert command. As it was supposed here #1788

Pantani

Heyy @ivanovpetr. Nice to see you contributing to Gaia. Some suggestions and one critical thing, the fmt.Errof don't have argument placeholders to pass the error description.

cmd/gaiad/cmd/bech32_convert.go

Pantani · 2022-10-25T10:58:01Z

cmd/gaiad/cmd/bech32_convert.go

+		Long: `Convert any bech32 string to the cosmos prefix
+
+Example:
+	gaiad debug bech32-convert akash1a6zlyvpnksx8wr6wz8wemur2xe8zyh0ytz6d88


Can you please provide an example with a different prefix? Using the prefix flag

I added one more example with prefix flag. Did I get your idea correctly?

nice!! The example is good. We can also update the description,

Convert any bech32 string prefix based on prefix flag. Default: "cosmos"

cmd/gaiad/cmd/bech32_convert.go

Pantani · 2022-10-25T11:03:27Z

Also, this is an excellent PR to introduce a pkg folder into the project. We can create a pkg/address with a conversion method to be reusable across the project.

codecov · 2022-10-25T12:08:18Z

Codecov Report

Merging #1845 (12d3a0f) into main (e76c32a) will increase coverage by 0.52%.
The diff coverage is 61.90%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1845      +/-   ##
==========================================
+ Coverage   43.26%   43.78%   +0.52%     
==========================================
  Files          15       17       +2     
  Lines        1343     1384      +41     
==========================================
+ Hits          581      606      +25     
- Misses        742      756      +14     
- Partials       20       22       +2

Pantani · 2022-10-25T12:11:06Z

Also, this is an excellent PR to introduce a pkg folder into the project. We can create a pkg/address with a conversion method to be reusable across the project.

we can also test the command if we create a separate method. Tests must be included. The PR must have 95% or more test coverage

Pantani · 2022-10-26T10:10:38Z

pkg/address/address.go

+)
+
+// ConvertBech32Prefix convert bech32 address to specified prefix.
+func ConvertBech32Prefix(address, prefix string) (string, error) {


Can you please add a test for this?

By the way it is not 100% covered is it okay?

…convert

…at/debug-bech32-convert

okwme

thank you for the contribution @ivanovpetr !
have wanted to use the feature myself in the past : )

Pantani

LGMT

* feat: Add command bech32-convert (#1845) * add bech32-convert command to gaiad * add changelog notice * add review fixes * add tests for ConvertBech32Prefix Co-authored-by: Petr Ivanov <petr.ivanov@tendermint.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * fix feegrant test accounts (#1861) * Updated and new links (#1862) * Updated and added links Current Telegram links directs to a chat that no longer exists, replaced it with the main Cosmos Telegram group. Also added link to Mintscan's list of on-chain proposals * Updated Telegram link: t.me/atomgov Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * chore: bump sdk to v0.46.4 (#1863) * chore: bump sdk * rename flag * prepare v8 release (#1860) * chore: changelog * chore: update changelog * chore: add changelog for v7.0.3 * chore: add v7.1.0 to changelog Co-authored-by: Yaru Wang <yaru@interchain.io> * Add backport for v8 & future v9/v10 (#1865) * Revert "prepare v8 release (#1860)" (#1866) This reverts commit f0397fd. * chore: changelog (#1868) * fix: print in app.go (#1878) * fix: print in app.go * fix: change print err to panic in init * refactor: simplify the logic in fee antehandler (#1877) * refactor: simplify the logic in fee antehandler * fix: test * test: add test for disable checkTx * fix: err check (#1880) * fix: change log.Fatal to panic, defer iter.Close() * update export.go * fix: lint * chore(deps): bump github.com/spf13/viper from 1.13.0 to 1.14.0 (#1885) Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.13.0 to 1.14.0. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.13.0...v1.14.0) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test: export genesis (#1871) * Add export test * Add unit test for app export * Refactor gaia helpers setup Co-authored-by: Danilo Pantani <danpantani@gmail.com> * fix(chore): fix gosec issues (#1881) * gosec improvements * fix gosec issues * defer to close iterator * add gas adjustment * Merge PR #1893: Delete CODE_OF_CONDUCT.md * test: Unit tests for global fee module (#1858) * test: add test for globalfee validateMinimumGasPrices * test: add test for querier * fix: panic in test * update test * update test * use original test * Update x/globalfee/types/params_test.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> * icamauth docs (#1813) * docs: add icamauth docs * docs: change uatom to stake * chore: update docs * docs: update icamuath.md according to review comments * docs: rename icamauth.md to README.md * docs: read mnemonic from file * docs: add hermes download instruction * update docs * globalfee/README.md -> globalfee.md * Update docs/modules/icamauth/hermes_setup.sh Co-authored-by: Danilo Pantani <danpantani@gmail.com> * docs: fix dead link * Update README.md * Update README.md * fixes Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> * docs: correct `NoWithVeto` condition description (#1900) According to (docs)[https://docs.cosmos.network/main/modules/gov#threshold] and [code](https://github.com/cosmos/cosmos-sdk/blob/bcff22a3767b9c5dd7d1d562aece90cf72e05e85/x/gov/keeper/tally.go#L115), it includes `abstain` when calculating the threshold of `NoWithVeto`. * fix(CI): fix code coverage (#1903) * fix the code test coverage measure * fix folder type removal * docs: update icamauth (#1905) * docs: update icamauth * docs: restructure icamauth docs * docs: update links * docs: fix dead links * chore: update docs (#1906) * feat(CI): skip run the go CI test for markdown/docs files (#1907) * skip run the test CI for markdown files * remove skip from the codeql ci * only ignore md files for codeql * feat(x/ica): add tests for icamauth module (#1897) * add unit tests methods * add tests for the types folder * remove query test * add test description * refactor: e2e test (#1840) * refactor: ica e2e test * refactor: globalfee e2e test * refactor: add execBankSendBatch * refactor: add const proposalGlobalFee * refactor: execBankSendBatch * Update tests/e2e/e2e_exec_test.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * test: refactor execBankSendBatch * fix: failure test Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update ibc-go v5.1.0 (#1898) * Strangelove/forward middleware atomic (#1911) * Update forward middleware to use packet memo field, async acks * fixed e2e Co-authored-by: Andrew Gouin <andrew@gouin.io> * fix bank migration in upgrade handler (#1892) * fix bank migtation in upgrade handler * try atomated upgrade test * fix build * change so runs on yml change too * change so runs on yml change too * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * passing upgrade test * Update app/upgrades/v8/upgrades.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update contrib/scripts/run-gaia-v7.sh Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update contrib/scripts/run-gaia-v7.sh Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update contrib/scripts/run-gaia-v7.sh Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update contrib/scripts/run-gaia-v7.sh Co-authored-by: Danilo Pantani <danpantani@gmail.com> * add unit test * Update app/upgrades/v8/upgrades_test.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * added check for deformed being removed Co-authored-by: Danilo Pantani <danpantani@gmail.com> * chore: simplify logic of getting allFees (#1917) * Updated codeowners, removed pantani, cmwaters & noomski * Makefile: add govulnchecker (#1927) Adds the Go vulnerability checker to the Makefile as a directive dependency to the all directive. Updates #1879 * spike to test feasibility of downgrade to v0.45 (#1902) * pause * no vscode errors * rewrite go.sum, go.work.sum and fix amino import * remove mauth docs * gofumpt * fix find * cant get docker to build locally * debug ibc test * fix ibc test * passing e2e * clean up commented out tests * remove more mauth * forgot to save * add back middleware test * fix upgrade * fix test setup * add TODO note * remove multihop test * Update docs/modules/gov.md * Update tests/e2e/query.go Co-authored-by: lg <8335464+glnro@users.noreply.github.com> * remove groups and gov docs * laurens comment re moduleAccountAddress * remove commented code that should not be added back Co-authored-by: lg <8335464+glnro@users.noreply.github.com> * feat: proto dependencies for downgrade to 0.45 (#1933) * feat: add third_party proto * feat: add script for generating go files from proto, and swagger * feat: add protoc-doc-gen.sh * fix: antehandler to fit sdk v0.45 (#1918) * pause * no vscode errors * rewrite go.sum, go.work.sum and fix amino import * remove mauth docs * gofumpt * fix find * cant get docker to build locally * debug ibc test * fix ibc test * passing e2e * clean up commented out tests * remove more mauth * forgot to save * add back middleware test * fix upgrade * fix test setup * add TODO note * remove multihop test * fix: antehandler in sdkv0.45 * test: add back globalfee e2e test * fix: failure of verifying sending token amount * chore: remove comments * feat: simplify fee logic Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * test re-org (#1913) * pause * no vscode errors * rewrite go.sum, go.work.sum and fix amino import * remove mauth docs * gofumpt * fix find * cant get docker to build locally * debug ibc test * fix ibc test * passing e2e * clean up commented out tests * remove more mauth * forgot to save * add back middleware test * fix upgrade * fix test setup * add TODO note * remove multihop test * re-organized tests to make it easier to skip when working on a single one * remove gov tests * removed multihop tests * markdownlint (#1936) * fix: feegrant e2e test (#1940) * docs: update state sync (#1946) * Updated roadmap (#1947) * bump versions, remove e2e go.mod (#1944) * bump versions, remove e2e go.mod * stupid gofumpt errors * fixed packet forward configuration (#1941) * exclude e2e tests from test coverage upload (#1953) * exclude e2e tests from test coverage upload * swap order of test to exclude e2e * remove e2e from find * updated gov docs as specified in issue #1948 (#1949) * updated gov docs as specified in issue #1948 * fixed links * missed a few links * fix links (#1954) * test: Refactor gov e2e for v0.45 Rho (#1951) * WIP * Refactor gov tests for v45 * Refactor gov and add community spend test * Refactor * Set explicit sdk & tm versions for all dependencies Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * Skip broken redirect link check * Restrict disable link to single link Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * add back TestGaiaApp_Export (#1955) * pause * unit pasing, check e2e * Update test_helpers.go * fix: put iterator in closure (#1934) Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com> * uncomment still existing test (#1956) * uncomment still existing test * forgot to include this file * pause * remove again * add back rest of tests * push e2e image and use released versions in docker push action (#1939) Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * lint tests, too (#1960) * feat: Change MaxBypassMinFeeMsgGasUsage via NewFeeDecorator (#1961) * change MaxBypassMinFeeMsgGasUsage easily * move test to newTestGasLimit * chore: remove unneeded replace tags (#1959) * remove unneeded replace tags * remove ibc dep * Update go.mod Co-authored-by: Marko Baricevic <markobaricevic3778@gmail.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * chore(docs): add code guidelines (#1819) * code guidelines * add resources * Update docs/code-guidelines.md Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * git guidelines * small fixes and final steps Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * Update ko genesis.md (#1964) * offboarding (#1969) * chore(deps): bump actions/cache from 3.0.10 to 3.2.0 (#1968) Bumps [actions/cache](https://github.com/actions/cache) from 3.0.10 to 3.2.0. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3.0.10...v3.2.0) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: fix global fee link (#1978) * chore(deps): bump github.com/gravity-devs/liquidity from 1.5.1 to 1.5.3 (#1981) Bumps [github.com/gravity-devs/liquidity](https://github.com/gravity-devs/liquidity) from 1.5.1 to 1.5.3. - [Release notes](https://github.com/gravity-devs/liquidity/releases) - [Changelog](https://github.com/Gravity-Devs/liquidity/blob/master/CHANGELOG.md) - [Commits](Gravity-Devs/liquidity@v1.5.1...v1.5.3) --- updated-dependencies: - dependency-name: github.com/gravity-devs/liquidity dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix: minor typos (#1984) Fix: minor typos * Migrations for quicksilver issue (#1976) * prepare v8 release (backport #1860) (#1867) * prepare v8 release (#1860) * chore: changelog * chore: update changelog * chore: add changelog for v7.0.3 * chore: add v7.1.0 to changelog Co-authored-by: Yaru Wang <yaru@interchain.io> (cherry picked from commit f0397fd) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * Added migrations for quicksilver stuck fund fix * Migrations for quicksilver * Check if balance of the refund addess is positive Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> Co-authored-by: lg <lauren@interchain.io> * test: remove unused const (#1988) * test: remove unused const * fix: lint * Changelog for V8 (#1982) * Update changelog for v8 * Update changelog for v8 * Update changelog * Make requested changes * Update date * Point to informal's fork of tendermint (#1990) * fix: remove ica controller params setup from upgrade handler (#1989) Signed-off-by: Yaru Wang <yaru@interchain.io> * Update codeowners (#1993) * preparing for v8.0.0-rc1 release (#1994) * prepare v8 release (backport #1860) (#1867) * prepare v8 release (#1860) * chore: changelog * chore: update changelog * chore: add changelog for v7.0.3 * chore: add v7.1.0 to changelog Co-authored-by: Yaru Wang <yaru@interchain.io> (cherry picked from commit f0397fd) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * docs: update changelog Signed-off-by: Yaru Wang <yaru@interchain.io> * docs: update docs Signed-off-by: Yaru Wang <yaru@interchain.io> Signed-off-by: Yaru Wang <yaru@interchain.io> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * docs: changelog for v8.0.0-rc1 (#1997) Signed-off-by: Yaru Wang <yaru@interchain.io> Signed-off-by: Yaru Wang <yaru@interchain.io> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Yaru Wang <yaru@interchain.io> Co-authored-by: Petr Ivanov <krest2005@yandex.ru> Co-authored-by: Petr Ivanov <petr.ivanov@tendermint.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> Co-authored-by: ZorroZ77 <94570964+ZorroZ77@users.noreply.github.com> Co-authored-by: Yaru Wang <yaru@interchain.io> Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: Yongwoo Lee <whylee259@gmail.com> Co-authored-by: Giancarlos Salas <giansalex@gmail.com> Co-authored-by: Andrew Gouin <andrew@gouin.io> Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com> Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> Co-authored-by: Lexa Michaelides <32111123+LexaMichaelides@users.noreply.github.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Marko Baricevic <markobaricevic3778@gmail.com> Co-authored-by: GwangIl-Park <40749130+GwangIl-Park@users.noreply.github.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: stana-ethernal <94966829+stana-ethernal@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* feat: Add command bech32-convert (#1845) * add bech32-convert command to gaiad * add changelog notice * add review fixes * add tests for ConvertBech32Prefix Co-authored-by: Petr Ivanov <petr.ivanov@tendermint.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * fix feegrant test accounts (#1861) * Updated and new links (#1862) * Updated and added links Current Telegram links directs to a chat that no longer exists, replaced it with the main Cosmos Telegram group. Also added link to Mintscan's list of on-chain proposals * Updated Telegram link: t.me/atomgov Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * chore: bump sdk to v0.46.4 (#1863) * chore: bump sdk * rename flag * prepare v8 release (#1860) * chore: changelog * chore: update changelog * chore: add changelog for v7.0.3 * chore: add v7.1.0 to changelog Co-authored-by: Yaru Wang <yaru@interchain.io> * Add backport for v8 & future v9/v10 (#1865) * Revert "prepare v8 release (#1860)" (#1866) This reverts commit f0397fd. * chore: changelog (#1868) * fix: print in app.go (#1878) * fix: print in app.go * fix: change print err to panic in init * refactor: simplify the logic in fee antehandler (#1877) * refactor: simplify the logic in fee antehandler * fix: test * test: add test for disable checkTx * fix: err check (#1880) * fix: change log.Fatal to panic, defer iter.Close() * update export.go * fix: lint * chore(deps): bump github.com/spf13/viper from 1.13.0 to 1.14.0 (#1885) Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.13.0 to 1.14.0. - [Release notes](https://github.com/spf13/viper/releases) - [Commits](spf13/viper@v1.13.0...v1.14.0) --- updated-dependencies: - dependency-name: github.com/spf13/viper dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test: export genesis (#1871) * Add export test * Add unit test for app export * Refactor gaia helpers setup Co-authored-by: Danilo Pantani <danpantani@gmail.com> * fix(chore): fix gosec issues (#1881) * gosec improvements * fix gosec issues * defer to close iterator * add gas adjustment * Merge PR #1893: Delete CODE_OF_CONDUCT.md * test: Unit tests for global fee module (#1858) * test: add test for globalfee validateMinimumGasPrices * test: add test for querier * fix: panic in test * update test * update test * use original test * Update x/globalfee/types/params_test.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> * icamauth docs (#1813) * docs: add icamauth docs * docs: change uatom to stake * chore: update docs * docs: update icamuath.md according to review comments * docs: rename icamauth.md to README.md * docs: read mnemonic from file * docs: add hermes download instruction * update docs * globalfee/README.md -> globalfee.md * Update docs/modules/icamauth/hermes_setup.sh Co-authored-by: Danilo Pantani <danpantani@gmail.com> * docs: fix dead link * Update README.md * Update README.md * fixes Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> * docs: correct `NoWithVeto` condition description (#1900) According to (docs)[https://docs.cosmos.network/main/modules/gov#threshold] and [code](https://github.com/cosmos/cosmos-sdk/blob/bcff22a3767b9c5dd7d1d562aece90cf72e05e85/x/gov/keeper/tally.go#L115), it includes `abstain` when calculating the threshold of `NoWithVeto`. * fix(CI): fix code coverage (#1903) * fix the code test coverage measure * fix folder type removal * docs: update icamauth (#1905) * docs: update icamauth * docs: restructure icamauth docs * docs: update links * docs: fix dead links * chore: update docs (#1906) * feat(CI): skip run the go CI test for markdown/docs files (#1907) * skip run the test CI for markdown files * remove skip from the codeql ci * only ignore md files for codeql * feat(x/ica): add tests for icamauth module (#1897) * add unit tests methods * add tests for the types folder * remove query test * add test description * refactor: e2e test (#1840) * refactor: ica e2e test * refactor: globalfee e2e test * refactor: add execBankSendBatch * refactor: add const proposalGlobalFee * refactor: execBankSendBatch * Update tests/e2e/e2e_exec_test.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * test: refactor execBankSendBatch * fix: failure test Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update ibc-go v5.1.0 (#1898) * Strangelove/forward middleware atomic (#1911) * Update forward middleware to use packet memo field, async acks * fixed e2e Co-authored-by: Andrew Gouin <andrew@gouin.io> * fix bank migration in upgrade handler (#1892) * fix bank migtation in upgrade handler * try atomated upgrade test * fix build * change so runs on yml change too * change so runs on yml change too * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * change again * passing upgrade test * Update app/upgrades/v8/upgrades.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update contrib/scripts/run-gaia-v7.sh Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update contrib/scripts/run-gaia-v7.sh Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update contrib/scripts/run-gaia-v7.sh Co-authored-by: Danilo Pantani <danpantani@gmail.com> * Update contrib/scripts/run-gaia-v7.sh Co-authored-by: Danilo Pantani <danpantani@gmail.com> * add unit test * Update app/upgrades/v8/upgrades_test.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * added check for deformed being removed Co-authored-by: Danilo Pantani <danpantani@gmail.com> * chore: simplify logic of getting allFees (#1917) * Updated codeowners, removed pantani, cmwaters & noomski * Makefile: add govulnchecker (#1927) Adds the Go vulnerability checker to the Makefile as a directive dependency to the all directive. Updates #1879 * spike to test feasibility of downgrade to v0.45 (#1902) * pause * no vscode errors * rewrite go.sum, go.work.sum and fix amino import * remove mauth docs * gofumpt * fix find * cant get docker to build locally * debug ibc test * fix ibc test * passing e2e * clean up commented out tests * remove more mauth * forgot to save * add back middleware test * fix upgrade * fix test setup * add TODO note * remove multihop test * Update docs/modules/gov.md * Update tests/e2e/query.go Co-authored-by: lg <8335464+glnro@users.noreply.github.com> * remove groups and gov docs * laurens comment re moduleAccountAddress * remove commented code that should not be added back Co-authored-by: lg <8335464+glnro@users.noreply.github.com> * feat: proto dependencies for downgrade to 0.45 (#1933) * feat: add third_party proto * feat: add script for generating go files from proto, and swagger * feat: add protoc-doc-gen.sh * fix: antehandler to fit sdk v0.45 (#1918) * pause * no vscode errors * rewrite go.sum, go.work.sum and fix amino import * remove mauth docs * gofumpt * fix find * cant get docker to build locally * debug ibc test * fix ibc test * passing e2e * clean up commented out tests * remove more mauth * forgot to save * add back middleware test * fix upgrade * fix test setup * add TODO note * remove multihop test * fix: antehandler in sdkv0.45 * test: add back globalfee e2e test * fix: failure of verifying sending token amount * chore: remove comments * feat: simplify fee logic Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * test re-org (#1913) * pause * no vscode errors * rewrite go.sum, go.work.sum and fix amino import * remove mauth docs * gofumpt * fix find * cant get docker to build locally * debug ibc test * fix ibc test * passing e2e * clean up commented out tests * remove more mauth * forgot to save * add back middleware test * fix upgrade * fix test setup * add TODO note * remove multihop test * re-organized tests to make it easier to skip when working on a single one * remove gov tests * removed multihop tests * markdownlint (#1936) * fix: feegrant e2e test (#1940) * docs: update state sync (#1946) * Updated roadmap (#1947) * bump versions, remove e2e go.mod (#1944) * bump versions, remove e2e go.mod * stupid gofumpt errors * fixed packet forward configuration (#1941) * exclude e2e tests from test coverage upload (#1953) * exclude e2e tests from test coverage upload * swap order of test to exclude e2e * remove e2e from find * updated gov docs as specified in issue #1948 (#1949) * updated gov docs as specified in issue #1948 * fixed links * missed a few links * fix links (#1954) * test: Refactor gov e2e for v0.45 Rho (#1951) * WIP * Refactor gov tests for v45 * Refactor gov and add community spend test * Refactor * Set explicit sdk & tm versions for all dependencies Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * Skip broken redirect link check * Restrict disable link to single link Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * add back TestGaiaApp_Export (#1955) * pause * unit pasing, check e2e * Update test_helpers.go * fix: put iterator in closure (#1934) Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com> * uncomment still existing test (#1956) * uncomment still existing test * forgot to include this file * pause * remove again * add back rest of tests * push e2e image and use released versions in docker push action (#1939) Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * lint tests, too (#1960) * feat: Change MaxBypassMinFeeMsgGasUsage via NewFeeDecorator (#1961) * change MaxBypassMinFeeMsgGasUsage easily * move test to newTestGasLimit * chore: remove unneeded replace tags (#1959) * remove unneeded replace tags * remove ibc dep * Update go.mod Co-authored-by: Marko Baricevic <markobaricevic3778@gmail.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * chore(docs): add code guidelines (#1819) * code guidelines * add resources * Update docs/code-guidelines.md Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * git guidelines * small fixes and final steps Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * Update ko genesis.md (#1964) * offboarding (#1969) * chore(deps): bump actions/cache from 3.0.10 to 3.2.0 (#1968) Bumps [actions/cache](https://github.com/actions/cache) from 3.0.10 to 3.2.0. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3.0.10...v3.2.0) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: fix global fee link (#1978) * chore(deps): bump github.com/gravity-devs/liquidity from 1.5.1 to 1.5.3 (#1981) Bumps [github.com/gravity-devs/liquidity](https://github.com/gravity-devs/liquidity) from 1.5.1 to 1.5.3. - [Release notes](https://github.com/gravity-devs/liquidity/releases) - [Changelog](https://github.com/Gravity-Devs/liquidity/blob/master/CHANGELOG.md) - [Commits](Gravity-Devs/liquidity@v1.5.1...v1.5.3) --- updated-dependencies: - dependency-name: github.com/gravity-devs/liquidity dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix: minor typos (#1984) Fix: minor typos * Migrations for quicksilver issue (#1976) * prepare v8 release (backport #1860) (#1867) * prepare v8 release (#1860) * chore: changelog * chore: update changelog * chore: add changelog for v7.0.3 * chore: add v7.1.0 to changelog Co-authored-by: Yaru Wang <yaru@interchain.io> (cherry picked from commit f0397fd) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * Added migrations for quicksilver stuck fund fix * Migrations for quicksilver * Check if balance of the refund addess is positive Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> Co-authored-by: lg <lauren@interchain.io> * test: remove unused const (#1988) * test: remove unused const * fix: lint * Changelog for V8 (#1982) * Update changelog for v8 * Update changelog for v8 * Update changelog * Make requested changes * Update date * Point to informal's fork of tendermint (#1990) * fix: remove ica controller params setup from upgrade handler (#1989) Signed-off-by: Yaru Wang <yaru@interchain.io> * Update codeowners (#1993) * preparing for v8.0.0-rc1 release (#1994) * prepare v8 release (backport #1860) (#1867) * prepare v8 release (#1860) * chore: changelog * chore: update changelog * chore: add changelog for v7.0.3 * chore: add v7.1.0 to changelog Co-authored-by: Yaru Wang <yaru@interchain.io> (cherry picked from commit f0397fd) # Conflicts: # CHANGELOG.md * Update CHANGELOG.md Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * docs: update changelog Signed-off-by: Yaru Wang <yaru@interchain.io> * docs: update docs Signed-off-by: Yaru Wang <yaru@interchain.io> Signed-off-by: Yaru Wang <yaru@interchain.io> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> * docs: changelog for v8.0.0-rc1 (#1997) Signed-off-by: Yaru Wang <yaru@interchain.io> Signed-off-by: Yaru Wang <yaru@interchain.io> * fix: correct ica wiring and update pfm fixes for v8 upgrade (#2008) * fix: remove duplicates of ica module * Remove ICAController * Add back ica new module config * Move migration run to end of upgrade * Update strangelove * Fix pfm * Add sdk logging * Add fix for pfm spelling mistake * Update ugrade handler logging, update pfm config * Fix linter * Update pfm * Update TransferKeeper to pass ChannelKeeper instead of RouterKeeper * Update pfm config * Update * Fix pfm again Co-authored-by: lg <lauren@interchain.io> * Update changelog for rc2 (#2022) * Update v8 backport rules (#2025) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Yaru Wang <yaru@interchain.io> Co-authored-by: Petr Ivanov <krest2005@yandex.ru> Co-authored-by: Petr Ivanov <petr.ivanov@tendermint.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> Co-authored-by: ZorroZ77 <94570964+ZorroZ77@users.noreply.github.com> Co-authored-by: Yaru Wang <yaru@interchain.io> Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jacob Gadikian <jacobgadikian@gmail.com> Co-authored-by: Yongwoo Lee <whylee259@gmail.com> Co-authored-by: Giancarlos Salas <giansalex@gmail.com> Co-authored-by: Andrew Gouin <andrew@gouin.io> Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com> Co-authored-by: Emmanuel T Odeke <emmanuel@orijtech.com> Co-authored-by: Lexa Michaelides <32111123+LexaMichaelides@users.noreply.github.com> Co-authored-by: Reece Williams <31943163+Reecepbcups@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Marko Baricevic <markobaricevic3778@gmail.com> Co-authored-by: GwangIl-Park <40749130+GwangIl-Park@users.noreply.github.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com> Co-authored-by: stana-ethernal <94966829+stana-ethernal@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

Petr Ivanov added 2 commits October 25, 2022 13:35

add bech32-convert command to gaiad

f2eb398

add changelog notice

b083d98

ivanovpetr requested review from okwme, alexanderbez, zmanian, yaruwangway, crodriguezvega, cmwaters, jackzampolin, mmulji-ic, glnro and Pantani as code owners October 25, 2022 09:54

Pantani suggested changes Oct 25, 2022

View reviewed changes

add review fixes

df75679

ivanovpetr requested a review from Pantani October 25, 2022 11:51

Merge branch 'main' into feat/debug-bech32-convert

135b5ff

Pantani reviewed Oct 26, 2022

View reviewed changes

Pantani and others added 4 commits October 27, 2022 12:34

Merge branch 'main' into feat/debug-bech32-convert

fe06362

Merge branch 'main' of github.com:cosmos/gaia into feat/debug-bech32-…

f10597f

…convert

Merge remote-tracking branch 'fork/feat/debug-bech32-convert' into fe…

2019a90

…at/debug-bech32-convert

add tests for ConvertBech32Prefix

78e71a0

okwme approved these changes Oct 28, 2022

View reviewed changes

Merge branch 'main' into feat/debug-bech32-convert

1d1b581

Pantani approved these changes Oct 31, 2022

View reviewed changes

Merge branch 'main' into feat/debug-bech32-convert

12d3a0f

okwme merged commit e3c65bd into cosmos:main Oct 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add command bech32-convert #1845

feat: Add command bech32-convert #1845

ivanovpetr commented Oct 25, 2022

Pantani left a comment

Pantani Oct 25, 2022

ivanovpetr Oct 25, 2022

Pantani Oct 25, 2022

Pantani commented Oct 25, 2022

codecov bot commented Oct 25, 2022 •

edited

Loading

Pantani commented Oct 25, 2022

Pantani Oct 26, 2022

ivanovpetr Oct 27, 2022

ivanovpetr Oct 27, 2022

okwme left a comment

Pantani left a comment

feat: Add command bech32-convert #1845

feat: Add command bech32-convert #1845

Conversation

ivanovpetr commented Oct 25, 2022

Pantani left a comment

Choose a reason for hiding this comment

Pantani Oct 25, 2022

Choose a reason for hiding this comment

ivanovpetr Oct 25, 2022

Choose a reason for hiding this comment

Pantani Oct 25, 2022

Choose a reason for hiding this comment

Pantani commented Oct 25, 2022

codecov bot commented Oct 25, 2022 • edited Loading

Codecov Report

Pantani commented Oct 25, 2022

Pantani Oct 26, 2022

Choose a reason for hiding this comment

ivanovpetr Oct 27, 2022

Choose a reason for hiding this comment

ivanovpetr Oct 27, 2022

Choose a reason for hiding this comment

okwme left a comment

Choose a reason for hiding this comment

Pantani left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 25, 2022 •

edited

Loading