Fix simapp dependence #1983
Merged
Fix simapp dependence #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glnro
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
jackzampolin and
mmulji-ic
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## glnro/ics-v45 #1983 +/- ##
==================================================
- Coverage 79.79% 69.42% -10.37%
==================================================
Files 23 26 +3
Lines 1589 1858 +269
==================================================
+ Hits 1268 1290 +22
- Misses 272 519 +247
Partials 49 49 |
|
Kudos, SonarCloud Quality Gate passed!
|
glnro
added a commit
that referenced
this pull request
Jan 17, 2023
* Update dependencies and compile * Add ICS * Add gov prop * Fix lint * Fix commenting * Fix commenting * Add GetStakingKeeper for ICS e2e test * Gaia implements ibc TestingApp * Update correct return type for GetStakingKeeper * Fix ibc import * Fix linting * Comment back LoadStreamingServices * Change IBC back to v3.4 * Fix ics post merge * Replace ibc with informal/ibc for e2e/ibctesting compatibility * Update ibc to 3.4.0 * Fix linting * Update gaia with new ics keeper interface * Add provider module to simulationModules * Bump ics * Fix sdk import * Update sdk to tagged release * Fix simapp dependence (#1983) * Fix simapp dependence * Fix coverage and linting * Update sim ignore * Update codecov rules * Update ics dependency * Update ICS dependency * Update code cov * Update ICS to tagged version * Update codecov * Add imported ICS test * Make requested test comment changes * Remove commented code Co-authored-by: Milan Mulji <98309852+mmulji-ic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes nondeterminism test failures and begins to address #1883