chore: replace sdk dependencies #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glnro
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
jtremback and
mpoke
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
mpoke
approved these changes
Jan 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
=======================================
Coverage 79.20% 79.20%
=======================================
Files 23 23
Lines 1577 1577
=======================================
Hits 1249 1249
Misses 274 274
Partials 54 54 |
MSalopek
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the following sdk dependencies. Thank you to @faddat for submitting the fix, either this pr or #2013 can be merged, whichever is ready earliest.
github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0
Includes a small feature the SDK needs
github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.4.2
Temporarily replaces jwt as done in the sdk until they remove it as a dependency...original dependency was deprecated and contains a security vulnerability
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.8.1
Temporarily replaces gin until the sdk removes it as a dependency. Fixes this security vulnerability.