Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faddat/consolidate #2076

Closed
wants to merge 2 commits into from
Closed

faddat/consolidate #2076

wants to merge 2 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jan 25, 2023

  • the launch repo is for gaia, not cosmos
  • having a networks folder makes it much easier for validators and others to start nodes
  • cosmos/mainnet should work correctly at all times, and in all versions
  • launch and mainnet repos should be archived

Deferring further work on this until v8 is completed

@faddat faddat force-pushed the faddat/consolidate branch from 60d589e to 3966e8f Compare January 25, 2023 14:07
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 6 Security Hotspots
Code Smell A 43 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #2076 (3966e8f) into main (a4d5b52) will increase coverage by 5.77%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2076      +/-   ##
==========================================
+ Coverage   79.08%   84.85%   +5.77%     
==========================================
  Files          23       21       -2     
  Lines        1568     1466     -102     
==========================================
+ Hits         1240     1244       +4     
+ Misses        274      177      -97     
+ Partials       54       45       -9     
Impacted Files Coverage Δ
app/modules.go 100.00% <0.00%> (ø)
app/upgrades/v8/upgrades.go
app/upgrades/v7/upgrades.go
app/keepers/keepers.go 98.90% <0.00%> (+1.75%) ⬆️
x/globalfee/module.go 88.67% <0.00%> (+3.77%) ⬆️
app/app.go 76.57% <0.00%> (+4.22%) ⬆️

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 13, 2023
@github-actions github-actions bot closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant