change bypass-min-fee-types parsing; change defaults #2092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
- Coverage 83.84% 83.40% -0.44%
==========================================
Files 22 22
Lines 1541 1555 +14
==========================================
+ Hits 1292 1297 +5
- Misses 201 207 +6
- Partials 48 51 +3
|
11 tasks
MSalopek
force-pushed
the
2087-bypass-config-parser
branch
from
f7e198b
to
3ff620b
Compare
MSalopek
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
sainoe and
shaspitz
as code owners
MSalopek
changed the title
yaruwangway
reviewed
Mar 15, 2023
|
we can add some e2e tests, let me know if you want me to add it |
|
this pr will be finally refactored. please see this issue. but lets still get it merged first, in case any decision changes later |
sainoe
approved these changes
Mar 15, 2023
MSalopek
force-pushed
the
2087-bypass-config-parser
branch
from
a058213
to
1620478
Compare
yaruwangway
approved these changes
Mar 16, 2023
|
changelog need to be added before merge. |
sainoe
reviewed
Mar 17, 2023
Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
* change bypass-min-fee-types parsing; change defaults * revert default message registration * docs: add changelog for fixing bypass parsing * Update CHANGELOG.md Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> --------- Co-authored-by: Yaru Wang <yaru@informal.systems> Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> (cherry picked from commit 4badbcd) # Conflicts: # CHANGELOG.md
sainoe
added a commit
that referenced
this pull request
Mar 21, 2023
…#2311) * change bypass-min-fee-types parsing; change defaults (#2092) * change bypass-min-fee-types parsing; change defaults * revert default message registration * docs: add changelog for fixing bypass parsing * Update CHANGELOG.md Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> --------- Co-authored-by: Yaru Wang <yaru@informal.systems> Co-authored-by: yaruwangway <69694322+yaruwangway@users.noreply.github.com> Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com> (cherry picked from commit 4badbcd) # Conflicts: # CHANGELOG.md * resolve conflict in changelog * debug upgrade script * bump cosmovisor --------- Co-authored-by: MSalopek <35486649+MSalopek@users.noreply.github.com> Co-authored-by: Simon Noetzlin <simon.ntz@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2087
Parsing of
bypass-min-fee-typesis changed to allow operators to use empty bypass list.The default was changed to be an empty list (no bypass allowed).
Removing the
bypass-min-fee-typesfromapp.tomlwill cause the default list of types to be used.Validation was added so strings not corresponding to any proto message types will cause a panic (since this is a misconfiguration, manual action should be required)
Logging was added to inform operators about bypass usage.
Behaviour
no key in the config filekey =key = [ ]key = ["value1", "value2"]